You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2018/09/27 16:27:00 UTC
spark git commit: [SPARK-25546][CORE] Don't cache value of
EVENT_LOG_CALLSITE_LONG_FORM.
Repository: spark
Updated Branches:
refs/heads/master a1adde540 -> 5fd22d053
[SPARK-25546][CORE] Don't cache value of EVENT_LOG_CALLSITE_LONG_FORM.
Caching the value of that config means different instances of SparkEnv
will always use whatever was the first value to be read. It also breaks
tests that use RDDInfo outside of the scope of a SparkContext.
Since this is not a performance sensitive area, there's no advantage
in caching the config value.
Closes #22558 from vanzin/SPARK-25546.
Authored-by: Marcelo Vanzin <va...@cloudera.com>
Signed-off-by: Dongjoon Hyun <do...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/5fd22d05
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/5fd22d05
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/5fd22d05
Branch: refs/heads/master
Commit: 5fd22d05363dd8c0e1b10f3822ccb71eb42f6db9
Parents: a1adde5
Author: Marcelo Vanzin <va...@cloudera.com>
Authored: Thu Sep 27 09:26:50 2018 -0700
Committer: Dongjoon Hyun <do...@apache.org>
Committed: Thu Sep 27 09:26:50 2018 -0700
----------------------------------------------------------------------
core/src/main/scala/org/apache/spark/storage/RDDInfo.scala | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/5fd22d05/core/src/main/scala/org/apache/spark/storage/RDDInfo.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/storage/RDDInfo.scala b/core/src/main/scala/org/apache/spark/storage/RDDInfo.scala
index 19f8656..917cfab 100644
--- a/core/src/main/scala/org/apache/spark/storage/RDDInfo.scala
+++ b/core/src/main/scala/org/apache/spark/storage/RDDInfo.scala
@@ -55,11 +55,13 @@ class RDDInfo(
}
private[spark] object RDDInfo {
- private val callsiteLongForm = SparkEnv.get.conf.get(EVENT_LOG_CALLSITE_LONG_FORM)
-
def fromRdd(rdd: RDD[_]): RDDInfo = {
val rddName = Option(rdd.name).getOrElse(Utils.getFormattedClassName(rdd))
val parentIds = rdd.dependencies.map(_.rdd.id)
+ val callsiteLongForm = Option(SparkEnv.get)
+ .map(_.conf.get(EVENT_LOG_CALLSITE_LONG_FORM))
+ .getOrElse(false)
+
val callSite = if (callsiteLongForm) {
rdd.creationSite.longForm
} else {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org