[jira] [Commented] (OAK-6479) misleading log entry when there's no revision to write to the journal

["Vikas Saurabh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-6479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096804#comment-16096804 ] 

Vikas Saurabh commented on OAK-6479:
------------------------------------

bq. so maybe it would be better to just backport all of OAK-3976?
I feel fine backporting OAK-3976. But, I'd like to have [~mreutegg]'s opinion too.

About the patch: While it won't impact the size of the patch a lot - but if we don't go for backporting OAK-3976, then the patch can make {{int numChangedNodes}} to {{boolean hasChangedNodes}} (and other changes accordingly to avoid counting which isn't required.

> misleading log entry when there's no revision to write to the journal
> ---------------------------------------------------------------------
>
>                 Key: OAK-6479
>                 URL: https://issues.apache.org/jira/browse/OAK-6479
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: documentmk
>    Affects Versions: 1.0.38, 1.2.26, 1.4.17
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>              Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
>         Attachments: OAK-6479.diff
>
>
> When there's no new revision to write to the journal, we see:
> {noformat}
> 21.06.2017 05:04:03.666 *ERROR* [DocumentNodeStore background update thread (1)] org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore Failed to write to journal, accumulating changes for future write (~112 bytes). 
> {noformat}
> This was fixed in 1.6 and newer as part of OAK-3976.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)