You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Pierre-Luc Dion <pd...@apache.org> on 2014/12/01 05:16:33 UTC
Re: Review Request 17335: cleanup around seemingly impossible cast
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17335/#review63333
-----------------------------------------------------------
Ship it!
commited: b838436e58a6e7df89d960c7805edc3fd3ed91a4
also added license header with commit: ed6016cf8ee655cb15796b8ffca9f6c29cf8d90d
- Pierre-Luc Dion
On Feb. 2, 2014, 5:03 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17335/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2014, 5:03 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Alex Huang, and Min Chen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - changed type parameters on details map in CreateSecondaryStagingStoreCmd - <String, String> was misleading since the it can not work with a string value and it is never a string
> - introducing the type parameters allowed some simplifications in getDetails()
> - added unit test
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmd.java 1480e75
> api/test/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmdTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17335/diff/
>
>
> Testing
> -------
>
> - all unit tests passed
> - checked all references and usage of the details field, injection with the @Parameter annotation
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 17335: cleanup around seemingly impossible cast
Posted by Pierre-Luc Dion <pd...@apache.org>.
> On Dec. 1, 2014, 4:16 a.m., Pierre-Luc Dion wrote:
> > commited: b838436e58a6e7df89d960c7805edc3fd3ed91a4
> > also added license header with commit: ed6016cf8ee655cb15796b8ffca9f6c29cf8d90d
Into master only.
- Pierre-Luc
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17335/#review63333
-----------------------------------------------------------
On Feb. 2, 2014, 5:03 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17335/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2014, 5:03 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Alex Huang, and Min Chen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - changed type parameters on details map in CreateSecondaryStagingStoreCmd - <String, String> was misleading since the it can not work with a string value and it is never a string
> - introducing the type parameters allowed some simplifications in getDetails()
> - added unit test
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmd.java 1480e75
> api/test/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmdTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17335/diff/
>
>
> Testing
> -------
>
> - all unit tests passed
> - checked all references and usage of the details field, injection with the @Parameter annotation
>
>
> Thanks,
>
> Laszlo Hornyak
>
>