You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "drewhayward (via GitHub)" <gi...@apache.org> on 2024/07/16 21:10:03 UTC
[PR] implement retract_batch for xor accumulator [datafusion]
drewhayward opened a new pull request, #11500:
URL: https://github.com/apache/datafusion/pull/11500
## Which issue does this PR close?
Closes #7666.
## What changes are included in this PR?
Implements the `retract_batch()` method for the `BitwiseXorAccumulator` by calling the original `update_batch` function since XOR is its own inverse.
## Are these changes tested?
Added a unit test for retracting the batch.
## Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] implement retract_batch for xor accumulator [datafusion]
Posted by "mustafasrepo (via GitHub)" <gi...@apache.org>.
mustafasrepo commented on code in PR #11500:
URL: https://github.com/apache/datafusion/pull/11500#discussion_r1680447853
##########
datafusion/functions-aggregate/src/bit_and_or_xor.rs:
##########
@@ -358,6 +358,14 @@ where
Ok(())
}
+ fn retract_batch(&mut self, values: &[ArrayRef]) -> Result<()> {
+ self.update_batch(values)
Review Comment:
Maybe you can add a comment here, stating explicitly inverse is same for xor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] implement retract_batch for xor accumulator [datafusion]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan merged PR #11500:
URL: https://github.com/apache/datafusion/pull/11500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] implement retract_batch for xor accumulator [datafusion]
Posted by "mustafasrepo (via GitHub)" <gi...@apache.org>.
mustafasrepo commented on code in PR #11500:
URL: https://github.com/apache/datafusion/pull/11500#discussion_r1680447853
##########
datafusion/functions-aggregate/src/bit_and_or_xor.rs:
##########
@@ -358,6 +358,14 @@ where
Ok(())
}
+ fn retract_batch(&mut self, values: &[ArrayRef]) -> Result<()> {
+ self.update_batch(values)
Review Comment:
Maybe you can add a comment here, stating explicitly inverse of the xor is itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] implement retract_batch for xor accumulator [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #11500:
URL: https://github.com/apache/datafusion/pull/11500#issuecomment-2231849997
Thanks @drewhayward -- @mustafasrepo do you have time to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org