You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2023/07/13 20:53:01 UTC
Review Request 74515: RANGER-4316: path recursive matcher fix to correctly handle path ending with separator
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74515/
-----------------------------------------------------------
Review request for ranger, Abhay Kulkarni, Monika Kachhadiya, Ramesh Mani, and Subhrat Chaudhary.
Bugs: RANGER-4316
https://issues.apache.org/jira/browse/RANGER-4316
Repository: ranger
Description
-------
updated path matcher to correctly handle path ending with separator
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcher.java 1af967fbd
agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcherTest.java 5e8efb720
agents-common/src/test/resources/resourcematcher/test_resourcematcher_path.json 97765f94d
Diff: https://reviews.apache.org/r/74515/diff/1/
Testing
-------
- added test cases to validate handling of paths ending with separator
- updated 2 existing test cases
- verified that all other test cases pass successfully
Thanks,
Madhan Neethiraj
Re: Review Request 74515: RANGER-4316: path recursive matcher fix to correctly handle path ending with separator
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74515/#review225605
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On July 13, 2023, 8:53 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74515/
> -----------------------------------------------------------
>
> (Updated July 13, 2023, 8:53 p.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Monika Kachhadiya, Ramesh Mani, and Subhrat Chaudhary.
>
>
> Bugs: RANGER-4316
> https://issues.apache.org/jira/browse/RANGER-4316
>
>
> Repository: ranger
>
>
> Description
> -------
>
> updated path matcher to correctly handle path ending with separator
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcher.java 1af967fbd
> agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcherTest.java 5e8efb720
> agents-common/src/test/resources/resourcematcher/test_resourcematcher_path.json 97765f94d
>
>
> Diff: https://reviews.apache.org/r/74515/diff/1/
>
>
> Testing
> -------
>
> - added test cases to validate handling of paths ending with separator
> - updated 2 existing test cases
> - verified that all other test cases pass successfully
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 74515: RANGER-4316: path recursive matcher fix to correctly handle path ending with separator
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74515/#review225606
-----------------------------------------------------------
Ship it!
Ship It!
- Ramesh Mani
On July 13, 2023, 8:53 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74515/
> -----------------------------------------------------------
>
> (Updated July 13, 2023, 8:53 p.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Monika Kachhadiya, Ramesh Mani, and Subhrat Chaudhary.
>
>
> Bugs: RANGER-4316
> https://issues.apache.org/jira/browse/RANGER-4316
>
>
> Repository: ranger
>
>
> Description
> -------
>
> updated path matcher to correctly handle path ending with separator
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcher.java 1af967fbd
> agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcherTest.java 5e8efb720
> agents-common/src/test/resources/resourcematcher/test_resourcematcher_path.json 97765f94d
>
>
> Diff: https://reviews.apache.org/r/74515/diff/1/
>
>
> Testing
> -------
>
> - added test cases to validate handling of paths ending with separator
> - updated 2 existing test cases
> - verified that all other test cases pass successfully
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 74515: RANGER-4316: path recursive matcher fix to correctly handle path ending with separator
Posted by Monika Kachhadiya via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74515/#review225604
-----------------------------------------------------------
Ship it!
Ship It!
- Monika Kachhadiya
On July 13, 2023, 8:53 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74515/
> -----------------------------------------------------------
>
> (Updated July 13, 2023, 8:53 p.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Monika Kachhadiya, Ramesh Mani, and Subhrat Chaudhary.
>
>
> Bugs: RANGER-4316
> https://issues.apache.org/jira/browse/RANGER-4316
>
>
> Repository: ranger
>
>
> Description
> -------
>
> updated path matcher to correctly handle path ending with separator
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcher.java 1af967fbd
> agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcherTest.java 5e8efb720
> agents-common/src/test/resources/resourcematcher/test_resourcematcher_path.json 97765f94d
>
>
> Diff: https://reviews.apache.org/r/74515/diff/1/
>
>
> Testing
> -------
>
> - added test cases to validate handling of paths ending with separator
> - updated 2 existing test cases
> - verified that all other test cases pass successfully
>
>
> Thanks,
>
> Madhan Neethiraj
>
>