[jira] [Commented] (PIG-1946) HBaseStorage constructor syntax is error prone

["Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031006#comment-13031006 ] 

Dmitriy V. Ryaboy commented on PIG-1946:
----------------------------------------

Bill, sorry it took me a while to get to this. Looks good, but I just confirmed that commas are valid in column names.. we should add escaping.

> HBaseStorage constructor syntax is error prone
> ----------------------------------------------
>
>                 Key: PIG-1946
>                 URL: https://issues.apache.org/jira/browse/PIG-1946
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Bill Graham
>            Assignee: Bill Graham
>             Fix For: 0.10
>
>         Attachments: PIG-1946_1.patch
>
>
> Using {{HBaseStorage}} like so seems like a reasonable thing to do, but it will yield unexpected results:
> {code}
> STORE result INTO 'hbase://foo' USING
>  org.apache.pig.backend.hadoop.hbase.HBaseStorage(
>  'info:first_name, info:last_name');
> {code}
> The problem us that a column named {{info:first_name,}} will be created, with the trailing comma included. I've had numerous developers get tripped up on this issue since everywhere else in Pig variables are separated by commas, so I propose we fix it.
> I propose we trim leading/trailing commas from column names, but I'm open to other ideas.
> Also should we accept column names that are comman-delimited without spaces?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira