You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2017/10/12 14:24:00 UTC
[GitHub] spark pull request #19484: [SPARK-22252][SQL][2.2] FileFormatWriter should r...
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/19484
[SPARK-22252][SQL][2.2] FileFormatWriter should respect the input query schema
## What changes were proposed in this pull request?
https://github.com/apache/spark/pull/19483 fixes SPARK-21165 but breaks SPARK-22252. This PR reverts https://github.com/apache/spark/pull/18386 and picks the patch from https://github.com/apache/spark/pull/19483 to fix SPARK-21165.
## How was this patch tested?
new regression test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloud-fan/spark bug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19484.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19484
----
commit 9d6417e93e6c536916224615e9ec27eadd659066
Author: Wenchen Fan <we...@databricks.com>
Date: 2017-10-12T13:16:50Z
Revert "[SPARK-21165] [SQL] [2.2] Use executedPlan instead of analyzedPlan in INSERT AS SELECT [WIP]"
This reverts commit b6749ba09724b3ed19166e7bb0b1fdcca79a44ba.
commit b625d41c9c155ace52d5667c6cbe2af6623da5a0
Author: Wenchen Fan <we...@databricks.com>
Date: 2017-10-12T13:24:10Z
tmp
commit 1a15cb276e8c82c01050287d63b2a87658d653bc
Author: Wenchen Fan <we...@databricks.com>
Date: 2017-10-12T14:20:10Z
FileFormatWriter should only rely on attributes from analyzed plan
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19484: [SPARK-22252][SQL][2.2] FileFormatWriter should r...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan closed the pull request at:
https://github.com/apache/spark/pull/19484
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19484: [SPARK-22252][SQL][2.2] FileFormatWriter should respect ...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19484
Thanks! Merged to 2.2. Could you close this?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19484: [SPARK-22252][SQL][2.2] FileFormatWriter should respect ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19484
**[Test build #82711 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82711/testReport)** for PR 19484 at commit [`e527540`](https://github.com/apache/spark/commit/e527540776f2016228dd7ae7ba4e45aff602401d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19484: [SPARK-22252][SQL][2.2] FileFormatWriter should respect ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19484
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19484: [SPARK-22252][SQL][2.2] FileFormatWriter should respect ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19484
**[Test build #82711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82711/testReport)** for PR 19484 at commit [`e527540`](https://github.com/apache/spark/commit/e527540776f2016228dd7ae7ba4e45aff602401d).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19484: [SPARK-22252][SQL][2.2] FileFormatWriter should respect ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19484
**[Test build #82684 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82684/testReport)** for PR 19484 at commit [`1a15cb2`](https://github.com/apache/spark/commit/1a15cb276e8c82c01050287d63b2a87658d653bc).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19484: [SPARK-22252][SQL][2.2] FileFormatWriter should respect ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19484
**[Test build #82684 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82684/testReport)** for PR 19484 at commit [`1a15cb2`](https://github.com/apache/spark/commit/1a15cb276e8c82c01050287d63b2a87658d653bc).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19484: [SPARK-22252][SQL][2.2] FileFormatWriter should respect ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19484
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19484: [SPARK-22252][SQL][2.2] FileFormatWriter should respect ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19484
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82684/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19484: [SPARK-22252][SQL][2.2] FileFormatWriter should respect ...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19484
cc @gatorsmile
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19484: [SPARK-22252][SQL][2.2] FileFormatWriter should respect ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19484
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82711/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19484: [SPARK-22252][SQL][2.2] FileFormatWriter should respect ...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19484
The PR description needs a correction.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org