You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "onobc (via GitHub)" <gi...@apache.org> on 2023/08/04 19:04:35 UTC

[GitHub] [pulsar-client-reactive] onobc opened a new pull request, #131: Update to Project Reactor to 3.6.0-M1

onobc opened a new pull request, #131:
URL: https://github.com/apache/pulsar-client-reactive/pull/131

   This updates to the version of the underlying Project Reactor to the 3.6.x line.
   
   Since the GA is not yet available, this locks on to the M1 in order to do preliminary verification.
   
   See #130
   
   cc: @cbornet @lhotari 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update to Project Reactor to 3.6.0 [pulsar-client-reactive]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #131:
URL: https://github.com/apache/pulsar-client-reactive/pull/131


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-reactive] onobc commented on a diff in pull request #131: Update to Project Reactor to 3.6.0-M1

Posted by "onobc (via GitHub)" <gi...@apache.org>.
onobc commented on code in PR #131:
URL: https://github.com/apache/pulsar-client-reactive/pull/131#discussion_r1284760218


##########
build.gradle:
##########
@@ -29,6 +29,7 @@ allprojects {
 
 	repositories {
 		mavenCentral()
+		maven { url 'https://repo.spring.io/milestone' }

Review Comment:
   **[TEMPORARY]** I am planning on keeping this PR open until reactor 3.6.0 goes GA. As more milestones are available I will add a subsequent commit that locks on the newest milestone (so on forth until GA). 
   
   The reason for the above approach is that my assumption is we are going to bump the project version from `0.3.0` to `0.4.0` when we update to Pulsar Client 3.0.0 in https://github.com/apache/pulsar-client-reactive/issues/126 and then from `0.4.0` to `0.5.0` for this change in Reactor. We could do them both in `0.4.0` but that would require the release of the pulsar client 3.0.0 change until Reactor is released in Nov 2023.  
   
   Thoughts?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org