You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Jan Høydahl (Jira)" <ji...@apache.org> on 2021/09/17 10:52:00 UTC
[jira] [Commented] (SOLR-15209) Make the AffinityPlacementFactory
the default placement plugin
[ https://issues.apache.org/jira/browse/SOLR-15209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416615#comment-17416615 ]
Jan Høydahl commented on SOLR-15209:
------------------------------------
I like the simplicity of AB's proposal. Perhaps coupled with an ENV_VAR override mechanism to "bootstrap". I.e.
# On startup, look for explicit placement plugin in ZK
# If explicit plugin configured in ZK, use that and continue
# If not configured, look in env.var SOLR_DEFAULT_PLACEMENT_PLUGIN (can have values "none", "affinity", "legacy", "random" etc) and use that
# If SOLR_DEFAULT_PLACEMENT_PLUGIN is not configured, use "affinity" as the default
# Write the resolved config to ZK
This way, users who are ignorant of this feature will get "affinity". Users who want to hand-edit zk can do that, optinally coupled with SOLR_DEFAULT_PLACEMENT_PLUGIN=none. And we also give users a quick way to select one of the built-in plugins without messing with clusterpropos and JSON.
> Make the AffinityPlacementFactory the default placement plugin
> --------------------------------------------------------------
>
> Key: SOLR-15209
> URL: https://issues.apache.org/jira/browse/SOLR-15209
> Project: Solr
> Issue Type: Improvement
> Reporter: Andrzej Bialecki
> Assignee: Ilan Ginzburg
> Priority: Major
>
> Currently there's a lot of code in {{Assign}} dealing with the fact that we still support the old "legacy" replica assignment as well as the new plugin-based placement strategies.
> Furthermore, the "legacy" assignment is now the default even though it's neither robust nor optimal, except in the very simple and small clusters. Also, providing another plugin-based placement as the default impl. runs into a small complication - in the absence of any plugin config the code reverts to the "legacy".
> In order to promote the adoption of the new plugin-based placements we should make the {{AffinityPlacementFactory}} the new default placement strategy, selected when the explicit configuration is missing (and then create it as a default configuration in {{PlacementPluginFactoryLoader}}).
> I propose to re-package the "legacy" strategy as a {{PlacementPluginFactory}} so that it can be configured in the same way as other placement plugins.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org