You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/30 14:45:57 UTC
[GitHub] [pulsar] codelipenghui opened a new pull request #14071: Fix unack message count for transaction Ack while disabled batch index ack
codelipenghui opened a new pull request #14071:
URL: https://github.com/apache/pulsar/pull/14071
### Motivation
Fix unack message count for transaction Ack while disabled batch index ack.
Transaction Ack is different with normal message ack for a batch message.
For normal message, we are using a bitset to carry the batch index state, for example
```
1. Ack with `00111111` means acks batch index 0 and 1
2. For ack batch index 2 and 3, the client will send `00001111` to broker
3. After all the batch been acked, send `00000000` to broker
```
The following is for transaction ack:
```
1. `00111111` means acks batch index 0 and 1
1. `11001111` means acks batch index 2 and 3
```
### Verification
Enabled transaction e2e test for batch index ack disabled
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [x] `no-need-doc`
(Please explain why)
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #14071: Fix unack message count for transaction Ack while disabled batch index ack
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #14071:
URL: https://github.com/apache/pulsar/pull/14071#discussion_r801358900
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndWithoutBatchIndexAckTest.java
##########
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.client.impl;
+
+import lombok.extern.slf4j.Slf4j;
+import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.Test;
+
+/**
+ * End to end transaction test.
+ */
+@Slf4j
+@Test(groups = "flaky")
Review comment:
Yes, because it will run all the tests under `TransactionEndToEndTest` which is in the flaky group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a change in pull request #14071: Fix unack message count for transaction Ack while disabled batch index ack
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on a change in pull request #14071:
URL: https://github.com/apache/pulsar/pull/14071#discussion_r801296527
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndWithoutBatchIndexAckTest.java
##########
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.client.impl;
+
+import lombok.extern.slf4j.Slf4j;
+import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.Test;
+
+/**
+ * End to end transaction test.
+ */
+@Slf4j
+@Test(groups = "flaky")
Review comment:
Is this a flaky test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14071: Fix unack message count for transaction Ack while disabled batch index ack
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14071:
URL: https://github.com/apache/pulsar/pull/14071#issuecomment-1025158592
@codelipenghui:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #14071: Fix unack message count for transaction Ack while disabled batch index ack
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14071:
URL: https://github.com/apache/pulsar/pull/14071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #14071: Fix unack message count for transaction Ack while disabled batch index ack
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #14071:
URL: https://github.com/apache/pulsar/pull/14071#issuecomment-1040658503
@codelipenghui - is this needed in 2.8? I noticed that the `BatchMessageWithBatchIndexLevelTest` is modified here and that created some conflicts for me when cherry picking https://github.com/apache/pulsar/pull/14288. I'm guessing 2.8 is fine, but just want to double check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org