You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "apupier (via GitHub)" <gi...@apache.org> on 2023/10/20 08:49:25 UTC
[PR] 20008 xml tokenizer expected bodies check without xml unit dependency on camel mock [camel]
apupier opened a new pull request, #11785:
URL: https://github.com/apache/camel/pull/11785
# Description
alternative implementation without a new dependency on an xml library on camel-mock
see https://github.com/apache/camel/pull/11756
include commit from https://github.com/apache/camel/pull/11754
# Target
- [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 20008 xml tokenizer expected bodies check without xml unit dependency on camel mock [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11785:
URL: https://github.com/apache/camel/pull/11785#issuecomment-1772594108
No it will not - if you are not able to do it, then you are welcome to close this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 20008 xml tokenizer expected bodies check without xml unit dependency on camel mock [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11785:
URL: https://github.com/apache/camel/pull/11785#issuecomment-1772335125
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 20008 xml tokenizer expected bodies check without xml unit dependency on camel mock [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11785:
URL: https://github.com/apache/camel/pull/11785#issuecomment-1772598820
I created a ticket about camel-mock
https://issues.apache.org/jira/browse/CAMEL-20020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 20008 xml tokenizer expected bodies check without xml unit dependency on camel mock [camel]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier closed pull request #11785: 20008 xml tokenizer expected bodies check without xml unit dependency on camel mock
URL: https://github.com/apache/camel/pull/11785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 20008 xml tokenizer expected bodies check without xml unit dependency on camel mock [camel]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on PR #11785:
URL: https://github.com/apache/camel/pull/11785#issuecomment-1772582036
> Can we please fix the XML tests without changing anything in camel-mock.
I think it will require to duplicate hundreds (if not thousands) of lines of codes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 20008 xml tokenizer expected bodies check without xml unit dependency on camel mock [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11785:
URL: https://github.com/apache/camel/pull/11785#issuecomment-1772526991
Can we please fix the XML tests without changing anything in camel-mock.
Changes to camel-mock is another conversation and needs more work to make a better API, there is already a bunch of methods, but some improvements can later be done with respect to Java 8 lambda style and whatnot.
But first we need to leave as-is and focus on Java 21 tests to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org