You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Benjamin Steinert (JIRA)" <ji...@apache.org> on 2012/10/08 11:24:03 UTC
[jira] [Created] (WICKET-4808) WebClientInfo.getRemoteAddr()
handling "Forwarded-For"value tokens not being ip addresses
Benjamin Steinert created WICKET-4808:
-----------------------------------------
Summary: WebClientInfo.getRemoteAddr() handling "Forwarded-For"value tokens not being ip addresses
Key: WICKET-4808
URL: https://issues.apache.org/jira/browse/WICKET-4808
Project: Wicket
Issue Type: Improvement
Components: wicket
Reporter: Benjamin Steinert
Priority: Minor
In some environments, it is possible and valid to have a Forwarded-For header in the request, not containing an ip address but a value like "unknown" or "hidden". (See also http://www.squid-cache.org/Doc/config/forwarded_for/ for example).
For that, I added tests and extended parsing logic with an address validation capable of parsing IPv4 and IPv6 values.
Cheers
Ben
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4808) WebClientInfo.getRemoteAddr()
handling "Forwarded-For"value tokens not being ip addresses
Posted by "Benjamin Steinert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Steinert updated WICKET-4808:
--------------------------------------
Attachment: imp-WICKET-4808.patch
> WebClientInfo.getRemoteAddr() handling "Forwarded-For"value tokens not being ip addresses
> -----------------------------------------------------------------------------------------
>
> Key: WICKET-4808
> URL: https://issues.apache.org/jira/browse/WICKET-4808
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Benjamin Steinert
> Priority: Minor
> Attachments: imp-WICKET-4808.patch
>
>
> In some environments, it is possible and valid to have a Forwarded-For header in the request, not containing an ip address but a value like "unknown" or "hidden". (See also http://www.squid-cache.org/Doc/config/forwarded_for/ for example).
> For that, I added tests and extended parsing logic with an address validation capable of parsing IPv4 and IPv6 values.
> Cheers
> Ben
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4808) WebClientInfo.getRemoteAddr()
handling "Forwarded-For" value tokens not being ip addresses
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4808.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.5.9
6.2.0
Assignee: Martin Grigorov
> WebClientInfo.getRemoteAddr() handling "Forwarded-For" value tokens not being ip addresses
> ------------------------------------------------------------------------------------------
>
> Key: WICKET-4808
> URL: https://issues.apache.org/jira/browse/WICKET-4808
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Benjamin Steinert
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 6.2.0, 1.5.9
>
> Attachments: imp-WICKET-4808.patch
>
>
> In some environments, it is possible and valid to have a Forwarded-For header in the request, not containing an ip address but a value like "unknown" or "hidden". (See also http://www.squid-cache.org/Doc/config/forwarded_for/ for example).
> For that, I added tests and extended parsing logic with an address validation capable of parsing IPv4 and IPv6 values.
> Cheers
> Ben
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4808) WebClientInfo.getRemoteAddr()
handling "Forwarded-For" value tokens not being ip addresses
Posted by "Benjamin Steinert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Steinert updated WICKET-4808:
--------------------------------------
Summary: WebClientInfo.getRemoteAddr() handling "Forwarded-For" value tokens not being ip addresses (was: WebClientInfo.getRemoteAddr() handling "Forwarded-For"value tokens not being ip addresses)
> WebClientInfo.getRemoteAddr() handling "Forwarded-For" value tokens not being ip addresses
> ------------------------------------------------------------------------------------------
>
> Key: WICKET-4808
> URL: https://issues.apache.org/jira/browse/WICKET-4808
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Benjamin Steinert
> Priority: Minor
> Attachments: imp-WICKET-4808.patch
>
>
> In some environments, it is possible and valid to have a Forwarded-For header in the request, not containing an ip address but a value like "unknown" or "hidden". (See also http://www.squid-cache.org/Doc/config/forwarded_for/ for example).
> For that, I added tests and extended parsing logic with an address validation capable of parsing IPv4 and IPv6 values.
> Cheers
> Ben
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira