You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/07/04 06:04:07 UTC
Review Request 23273: Configure H2 to use a named (non-private) database,
and not close the database.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23273/
-----------------------------------------------------------
Review request for Aurora and Kevin Sweeney.
Bugs: AURORA-573
https://issues.apache.org/jira/browse/AURORA-573
Repository: aurora
Description
-------
Configure H2 to use a named (non-private) database, and not close the database.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 348527997ea89fd71952a9f1ec0c67c3087f5a61
Diff: https://reviews.apache.org/r/23273/diff/
Testing
-------
./gradlew build -Pq
Also attempted to repro as explained in AURORA-573, and i can no longer trigger a SQL exception.
Thanks,
Bill Farner
Re: Review Request 23273: Configure H2 to use a named (non-private) database,
and not close the database.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23273/#review47335
-----------------------------------------------------------
Ship it!
I'm going to commit in advance of review, given how serious the bug is.
- Bill Farner
On July 4, 2014, 4:04 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23273/
> -----------------------------------------------------------
>
> (Updated July 4, 2014, 4:04 a.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-573
> https://issues.apache.org/jira/browse/AURORA-573
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Configure H2 to use a named (non-private) database, and not close the database.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 348527997ea89fd71952a9f1ec0c67c3087f5a61
>
> Diff: https://reviews.apache.org/r/23273/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
> Also attempted to repro as explained in AURORA-573, and i can no longer trigger a SQL exception.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 23273: Configure H2 to use a named (non-private) database,
and not close the database.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23273/
-----------------------------------------------------------
(Updated July 4, 2014, 4:41 a.m.)
Review request for Aurora and Kevin Sweeney.
Bugs: AURORA-573
https://issues.apache.org/jira/browse/AURORA-573
Repository: aurora
Description
-------
Configure H2 to use a named (non-private) database, and not close the database.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 348527997ea89fd71952a9f1ec0c67c3087f5a61
src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java cc206314d93ea7b160df7f809d072f90e23cc4b3
src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java 3a50454700804e163fc71f688cc132f27c5de9e5
src/test/java/org/apache/aurora/scheduler/storage/db/DbQuotaStoreTest.java 21151f5999452e6b90603ba3f3248d8f714f8dca
Diff: https://reviews.apache.org/r/23273/diff/
Testing
-------
./gradlew build -Pq
Also attempted to repro as explained in AURORA-573, and i can no longer trigger a SQL exception.
Thanks,
Bill Farner