You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by co...@apache.org on 2008/08/04 15:49:07 UTC
svn commit: r682389 - in /httpd/httpd/trunk: CHANGES
modules/generators/mod_cgid.c
Author: covener
Date: Mon Aug 4 06:49:07 2008
New Revision: 682389
URL: http://svn.apache.org/viewvc?rev=682389&view=rev
Log:
*) mod_cgid: Pass along empty command line arguments from an ISINDEX
query that has consecutive '+' characters in the QUERY_STRING,
matching the behavior of mod_cgi.
Modified:
httpd/httpd/trunk/CHANGES
httpd/httpd/trunk/modules/generators/mod_cgid.c
Modified: httpd/httpd/trunk/CHANGES
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/CHANGES?rev=682389&r1=682388&r2=682389&view=diff
==============================================================================
--- httpd/httpd/trunk/CHANGES [utf-8] (original)
+++ httpd/httpd/trunk/CHANGES [utf-8] Mon Aug 4 06:49:07 2008
@@ -2,6 +2,11 @@
Changes with Apache 2.3.0
[ When backported to 2.2.x, remove entry from this file ]
+ *) mod_cgid: Pass along empty command line arguments from an ISINDEX
+ query that has consecutive '+' characters in the QUERY_STRING,
+ matching the behavior of mod_cgi.
+ [Eric Covener]
+
*) mod_auth_core: Detect during startup when AuthDigestProvider
is configured to use an incompatible provider via AuthnProviderAlias.
PR 45196 [Eric Covener]
Modified: httpd/httpd/trunk/modules/generators/mod_cgid.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/generators/mod_cgid.c?rev=682389&r1=682388&r2=682389&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/generators/mod_cgid.c (original)
+++ httpd/httpd/trunk/modules/generators/mod_cgid.c Mon Aug 4 06:49:07 2008
@@ -237,6 +237,9 @@
ap_unescape_url(w);
av[idx++] = ap_escape_shell_cmd(p, w);
}
+ else {
+ av[idx++] = w;
+ }
}
av[idx] = NULL;
return av;
Re: svn commit: r682389 - in /httpd/httpd/trunk: CHANGES modules/generators/mod_cgid.c
Posted by Eric Covener <co...@gmail.com>.
> Thanks for keeping track of this. Wouldn't it make sense to keep the
> code identical in mod_cgi and mod_cgid?
Jim got this in r682475 before I could ACK. I updated the backport proposal.
Thanks for the review.
--
Eric Covener
covener@gmail.com
Re: svn commit: r682389 - in /httpd/httpd/trunk: CHANGES modules/generators/mod_cgid.c
Posted by Ruediger Pluem <rp...@apache.org>.
On 08/04/2008 03:49 PM, covener@apache.org wrote:
> Author: covener
> Date: Mon Aug 4 06:49:07 2008
> New Revision: 682389
>
> URL: http://svn.apache.org/viewvc?rev=682389&view=rev
> Log:
> *) mod_cgid: Pass along empty command line arguments from an ISINDEX
> query that has consecutive '+' characters in the QUERY_STRING,
> matching the behavior of mod_cgi.
>
>
> Modified:
> httpd/httpd/trunk/CHANGES
> httpd/httpd/trunk/modules/generators/mod_cgid.c
> Modified: httpd/httpd/trunk/modules/generators/mod_cgid.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/generators/mod_cgid.c?rev=682389&r1=682388&r2=682389&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/generators/mod_cgid.c (original)
> +++ httpd/httpd/trunk/modules/generators/mod_cgid.c Mon Aug 4 06:49:07 2008
> @@ -237,6 +237,9 @@
> ap_unescape_url(w);
> av[idx++] = ap_escape_shell_cmd(p, w);
> }
> + else {
> + av[idx++] = w;
> + }
> }
> av[idx] = NULL;
> return av;
Thanks for keeping track of this. Wouldn't it make sense to keep the
code identical in mod_cgi and mod_cgid?
Regards
Rüdiger