You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Krisztian Kasa <kk...@hortonworks.com> on 2020/02/11 09:58:31 UTC
Review Request 72108: HIVE-22867
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72108/
-----------------------------------------------------------
Review request for hive, Attila Magyar and Jesús Camacho Rodríguez.
Bugs: HIVE-22867
https://issues.apache.org/jira/browse/HIVE-22867
Repository: hive-git
Description
-------
Add partitioning support to VectorTopNKeyOperator
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/TopNKeyOperator.java bd8ff6285e
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorTopNKeyOperator.java f03d65030d
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 27ff0c2484
ql/src/java/org/apache/hadoop/hive/ql/plan/VectorTopNKeyDesc.java 9a266a0c57
ql/src/test/queries/clientpositive/subquery_in.q 96ed1bae41
ql/src/test/queries/clientpositive/subquery_notin.q f25168ab77
ql/src/test/queries/clientpositive/topnkey_windowing.q a5352d2d6c
ql/src/test/queries/clientpositive/vector_windowing_streaming.q 2f7b628db3
ql/src/test/queries/clientpositive/windowing_filter.q 14d0c5a7c8
ql/src/test/results/clientpositive/llap/subquery_in.q.out ea8fe5ea96
ql/src/test/results/clientpositive/llap/subquery_notin.q.out c24b79db86
ql/src/test/results/clientpositive/llap/topnkey_windowing.q.out 52ba490c01
ql/src/test/results/clientpositive/llap/vector_windowing_streaming.q.out b63bcf47f3
ql/src/test/results/clientpositive/llap/windowing_filter.q.out 8ef2261755
ql/src/test/results/clientpositive/topnkey_windowing.q.out c186790bea
Diff: https://reviews.apache.org/r/72108/diff/1/
Testing
-------
mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=vector_windowing_streaming.q,subquery_notin.q,subquery_in.q,windowing_filter.q,topnkey_windowing.q -pl itests/qtest -Pitests
Thanks,
Krisztian Kasa
Re: Review Request 72108: HIVE-22867
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72108/#review219544
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Magyar
On Feb. 11, 2020, 9:58 a.m., Krisztian Kasa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72108/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2020, 9:58 a.m.)
>
>
> Review request for hive, Attila Magyar and Jesús Camacho Rodríguez.
>
>
> Bugs: HIVE-22867
> https://issues.apache.org/jira/browse/HIVE-22867
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Add partitioning support to VectorTopNKeyOperator
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/TopNKeyOperator.java bd8ff6285e
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorTopNKeyOperator.java f03d65030d
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 27ff0c2484
> ql/src/java/org/apache/hadoop/hive/ql/plan/VectorTopNKeyDesc.java 9a266a0c57
> ql/src/test/queries/clientpositive/subquery_in.q 96ed1bae41
> ql/src/test/queries/clientpositive/subquery_notin.q f25168ab77
> ql/src/test/queries/clientpositive/topnkey_windowing.q a5352d2d6c
> ql/src/test/queries/clientpositive/vector_windowing_streaming.q 2f7b628db3
> ql/src/test/queries/clientpositive/windowing_filter.q 14d0c5a7c8
> ql/src/test/results/clientpositive/llap/subquery_in.q.out ea8fe5ea96
> ql/src/test/results/clientpositive/llap/subquery_notin.q.out c24b79db86
> ql/src/test/results/clientpositive/llap/topnkey_windowing.q.out 52ba490c01
> ql/src/test/results/clientpositive/llap/vector_windowing_streaming.q.out b63bcf47f3
> ql/src/test/results/clientpositive/llap/windowing_filter.q.out 8ef2261755
> ql/src/test/results/clientpositive/topnkey_windowing.q.out c186790bea
>
>
> Diff: https://reviews.apache.org/r/72108/diff/1/
>
>
> Testing
> -------
>
> mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=vector_windowing_streaming.q,subquery_notin.q,subquery_in.q,windowing_filter.q,topnkey_windowing.q -pl itests/qtest -Pitests
>
>
> Thanks,
>
> Krisztian Kasa
>
>
Re: Review Request 72108: HIVE-22867
Posted by Krisztian Kasa <kk...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72108/
-----------------------------------------------------------
(Updated Feb. 12, 2020, 10:09 a.m.)
Review request for hive, Attila Magyar and Jesús Camacho Rodríguez.
Bugs: HIVE-22867
https://issues.apache.org/jira/browse/HIVE-22867
Repository: hive-git
Description
-------
Add partitioning support to VectorTopNKeyOperator
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/TopNKeyOperator.java bd8ff6285e
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorTopNKeyOperator.java f03d65030d
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 27ff0c2484
ql/src/java/org/apache/hadoop/hive/ql/plan/VectorTopNKeyDesc.java 9a266a0c57
ql/src/test/queries/clientpositive/subquery_in.q 96ed1bae41
ql/src/test/queries/clientpositive/subquery_notin.q f25168ab77
ql/src/test/queries/clientpositive/topnkey_windowing.q a5352d2d6c
ql/src/test/queries/clientpositive/vector_windowing_streaming.q 2f7b628db3
ql/src/test/queries/clientpositive/windowing_filter.q 14d0c5a7c8
ql/src/test/results/clientpositive/llap/subquery_in.q.out ea8fe5ea96
ql/src/test/results/clientpositive/llap/subquery_notin.q.out c24b79db86
ql/src/test/results/clientpositive/llap/topnkey_windowing.q.out 52ba490c01
ql/src/test/results/clientpositive/llap/vector_case_when_conversion.q.out 74899062a5
ql/src/test/results/clientpositive/llap/vector_coalesce.q.out d767d7dc21
ql/src/test/results/clientpositive/llap/vector_decimal_expressions.q.out 84ce5882e2
ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_limit.q.out b7ea74938f
ql/src/test/results/clientpositive/llap/vector_string_concat.q.out beb02579ea
ql/src/test/results/clientpositive/llap/vector_windowing_streaming.q.out b63bcf47f3
ql/src/test/results/clientpositive/llap/vectorization_13.q.out 7e41c9dc54
ql/src/test/results/clientpositive/llap/vectorization_7.q.out 6f5f3a6a68
ql/src/test/results/clientpositive/llap/vectorization_8.q.out 4cd53cb311
ql/src/test/results/clientpositive/llap/vectorization_div0.q.out 427e2767ba
ql/src/test/results/clientpositive/llap/vectorization_short_regress.q.out fe80a40620
ql/src/test/results/clientpositive/llap/windowing_filter.q.out 8ef2261755
ql/src/test/results/clientpositive/topnkey_windowing.q.out c186790bea
Diff: https://reviews.apache.org/r/72108/diff/2/
Changes: https://reviews.apache.org/r/72108/diff/1-2/
Testing
-------
mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=vector_windowing_streaming.q,subquery_notin.q,subquery_in.q,windowing_filter.q,topnkey_windowing.q -pl itests/qtest -Pitests
Thanks,
Krisztian Kasa