[GitHub] [arrow] andygrove commented on pull request #8785: ARROW-10729: [Rust] [DataFusion] Add SQL support for JOIN using implicit syntax [WIP]

[GitBox <gi...@apache.org>]

andygrove commented on pull request #8785:
URL: https://github.com/apache/arrow/pull/8785#issuecomment-734903494


   @jorgecarleitao This code is basically working but I think it has exposed a bug in the filter push down logic where it tries to push a filter down through the join where the expression is `left_column = right_column` so it is not valid to push this through the join because it depends on the output from the join.
   
   ```
   ---- equijoin_implicit_syntax stdout ----
   thread 'equijoin_implicit_syntax' panicked at 'Creating physical plan for 'SELECT t1_id, t1_name, t2_name FROM t1, t2 WHERE t1_id = t2_id ORDER BY t1_id': Sort: #t1_id ASC NULLS FIRST
     Projection: #t1_id, #t1_name, #t2_name
       Join: t1_id = t2_id
         Filter: #t1_id Eq #t2_id
           TableScan: t1 projection=Some([0, 1])
         Filter: #t1_id Eq #t2_id
           TableScan: t2 projection=Some([0, 1]): ArrowError(InvalidArgumentError("Unable to get field named \"t2_id\". Valid fields: [\"t1_id\", \"t1_name\"]"))', datafusion/tests/sql.rs:1243:48
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org