You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Stefan Bodewig <bo...@apache.org> on 2018/04/09 07:41:34 UTC
Re: ant git commit: Use isEmpty() in tasks
On 2018-04-06, <gi...@apache.org> wrote:
> http://git-wip-us.apache.org/repos/asf/ant/blob/73bda1fb/src/main/org/apache/tools/ant/taskdefs/BindTargets.java
> ----------------------------------------------------------------------
> diff --git a/src/main/org/apache/tools/ant/taskdefs/BindTargets.java b/src/main/org/apache/tools/ant/taskdefs/BindTargets.java
> index 3ac33f5..7beac61 100644
> --- a/src/main/org/apache/tools/ant/taskdefs/BindTargets.java
>>>> b/src/main/org/apache/tools/ant/taskdefs/BindTargets.java
> @@ -65,7 +65,7 @@ public class BindTargets extends Task {
> }
> if (getOwningTarget() == null
> - || !"".equals(getOwningTarget().getName())) {
> + || getOwningTarget().getName().isEmpty()) {
> throw new BuildException("bindtargets only allowed as a top-level task");
> }
You've reverse the logic by accident.
This broke running the tests locally as well as in Jenkins, I've fixed
it now.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org