[GitHub] [hbase] Apache9 commented on a change in pull request #1990: HBASE-24648 Remove the legacy 'forceSplit' related code at region ser…

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #1990:
URL: https://github.com/apache/hbase/pull/1990#discussion_r446663811



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java
##########
@@ -167,12 +167,15 @@ public RegionInfo getDaughterTwoRI() {
     return daughterTwoRI;
   }
 
+  private boolean hasBestSplitRow() {
+    return bestSplitRow != null && bestSplitRow.length > 0;
+  }
+
   /**
    * Check whether the region is splittable
    * @param env MasterProcedureEnv
    * @param regionToSplit parent Region to be split
    * @param splitRow if splitRow is not specified, will first try to get bestSplitRow from RS
-   * @throws IOException

Review comment:
       Empty throws will lead to a checkstyle warning.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org