[GitHub] apeforest commented on a change in pull request #12290: [MXNET-798][WIP] Fix the dtype cast from non float32 in Gradient computation

[GitBox <gi...@apache.org>]

apeforest commented on a change in pull request #12290: [MXNET-798][WIP] Fix the dtype cast from non float32 in Gradient computation
URL: https://github.com/apache/incubator-mxnet/pull/12290#discussion_r212695363
 
 

 ##########
 File path: src/executor/infer_graph_attr_pass.cc
 ##########
 @@ -254,7 +254,8 @@ nnvm::Graph InferAttr(nnvm::Graph &&ret,
         dispatch_mode = &dispatch_modes[nid];
         if (dispatch_modes[nid] == DispatchMode::kUndefined) forward_known = false;
       }
-      auto finfer = finfer_shape.get(inode.source->op(), fdefault);
+      auto finfer = (inode.source->op() == Op::Get("_zeros")) ? fdefault :
+        finfer_shape.get(inode.source->op(), fdefault);
 
 Review comment:
   You are right, this is breaking some unit test (however, due to unittest of master branch is broken in MacOS, I wan't able to verify before checkin). I have changed the PR to WIP. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services