You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Michael Greene (JIRA)" <ji...@apache.org> on 2009/08/03 21:53:15 UTC
[jira] Created: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Fix low-hanging scoping and other issues picked up by findbugs
--------------------------------------------------------------
Key: CASSANDRA-338
URL: https://issues.apache.org/jira/browse/CASSANDRA-338
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 0.4
Reporter: Michael Greene
Priority: Trivial
Fix For: 0.4
Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Edward Ribeiro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741116#action_12741116 ]
Edward Ribeiro commented on CASSANDRA-338:
------------------------------------------
Nice to know that findbugs is being used to check the code base cleanness. I've posted and patched some issues discovered by findbugs in the past.
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Assignee: Michael Greene
> Priority: Trivial
> Attachments: CASSANDRA-338-CCE.diff, cassandra-findbugs-1.diff, cassandra-findbugs-2.diff, findbugs-2nd-addendum.diff, findbugs-2ndset-1.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-338:
-------------------------------------
Attachment: findbugs-2nd-addendum.diff
addendup to patch 2:
instead of adding hashcode to classes that override equals unnecessarily, r/m the equals method.
instead of adding null checks to variables that Should Never Be Null, add assert != null.
look ok?
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: cassandra-findbugs-1.diff, cassandra-findbugs-2.diff, findbugs-2nd-addendum.diff, findbugs-2ndset-1.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738567#action_12738567 ]
Jonathan Ellis commented on CASSANDRA-338:
------------------------------------------
committed
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: cassandra-findbugs-1.diff, cassandra-findbugs-2.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738550#action_12738550 ]
Michael Greene commented on CASSANDRA-338:
------------------------------------------
Row already implemented the functionality for Serializable, it just didn't declare itself as such. It should, because ReadResponse is Serializable and contains a Row. Our serializer implementation for ReadResponse just knows about Row's serializer, but findbugs was compelling me to make Java know about it as well.
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: cassandra-findbugs-1.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740884#action_12740884 ]
Hudson commented on CASSANDRA-338:
----------------------------------
Integrated in Cassandra #161 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/161/])
fix broken casts. patch by Bill de hOra; reviewed by jbellis for
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: CASSANDRA-338-CCE.diff, cassandra-findbugs-1.diff, cassandra-findbugs-2.diff, findbugs-2nd-addendum.diff, findbugs-2ndset-1.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738552#action_12738552 ]
Jonathan Ellis commented on CASSANDRA-338:
------------------------------------------
ah, so the real bug is that ReadResponse implements Serializable, when it doesn't need to (relic of really old FB code)
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: cassandra-findbugs-1.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-338:
-------------------------------------
Fix Version/s: (was: 0.4)
Assignee: Michael Greene
removing 0.4 tag since it's more open-ended than that
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Assignee: Michael Greene
> Priority: Trivial
> Attachments: CASSANDRA-338-CCE.diff, cassandra-findbugs-1.diff, cassandra-findbugs-2.diff, findbugs-2nd-addendum.diff, findbugs-2ndset-1.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Bill de hOra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill de hOra updated CASSANDRA-338:
-----------------------------------
Attachment: CASSANDRA-338-CCE.diff
Fixes two bad classcasts in StorageService. But I'm wondering if this hasn't blown up to date whether the path ever gets executed?
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: cassandra-findbugs-1.diff, cassandra-findbugs-2.diff, findbugs-2nd-addendum.diff, findbugs-2ndset-1.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740787#action_12740787 ]
Jonathan Ellis commented on CASSANDRA-338:
------------------------------------------
applied (minus the unit tests -- the effort is appreciated, but it doesn't actually exercise any code in StorageService), thanks!
> I'm wondering if this hasn't blown up to date whether the path ever gets executed?
It isn't. Sandeep, is that code fragment (StorageService.forceHandoff) going to be useful at all for CASSANDRA-195? If not let's nuke it.
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: CASSANDRA-338-CCE.diff, cassandra-findbugs-1.diff, cassandra-findbugs-2.diff, findbugs-2nd-addendum.diff, findbugs-2ndset-1.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-338:
-------------------------------------
Fix Version/s: 0.9
ok, moving to release-after-0.5 so i remember to bug you in that time frame :)
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Assignee: Michael Greene
> Priority: Trivial
> Fix For: 0.9
>
> Attachments: CASSANDRA-338-CCE.diff, cassandra-findbugs-1.diff, cassandra-findbugs-2.diff, findbugs-2nd-addendum.diff, findbugs-2ndset-1.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739476#action_12739476 ]
Michael Greene commented on CASSANDRA-338:
------------------------------------------
Yes in both cases if the presumptions are true.
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: cassandra-findbugs-1.diff, cassandra-findbugs-2.diff, findbugs-2nd-addendum.diff, findbugs-2ndset-1.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-338.
--------------------------------------
Resolution: Fixed
closing in favor of Stu's more recent findbugs tickets
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Assignee: Michael Greene
> Priority: Trivial
> Fix For: 0.9
>
> Attachments: CASSANDRA-338-CCE.diff, cassandra-findbugs-1.diff, cassandra-findbugs-2.diff, findbugs-2nd-addendum.diff, findbugs-2ndset-1.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775072#action_12775072 ]
Jonathan Ellis commented on CASSANDRA-338:
------------------------------------------
should this be closed?
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Assignee: Michael Greene
> Priority: Trivial
> Attachments: CASSANDRA-338-CCE.diff, cassandra-findbugs-1.diff, cassandra-findbugs-2.diff, findbugs-2nd-addendum.diff, findbugs-2ndset-1.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740043#action_12740043 ]
Hudson commented on CASSANDRA-338:
----------------------------------
Integrated in Cassandra #159 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/159/])
fix more findbugs complaints. patch by Michael Greene; reviewed by jbellis for
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: cassandra-findbugs-1.diff, cassandra-findbugs-2.diff, findbugs-2nd-addendum.diff, findbugs-2ndset-1.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-338:
-------------------------------------
Attachment: findbugs-2ndset-1.diff
This is a second set of fixes to potential problems caught by findbugs. Brings bug count from 250 -> 239.
For what it's worth, about 150 of the remaining are out of our control through ANTLR or Thrift.
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: cassandra-findbugs-1.diff, cassandra-findbugs-2.diff, findbugs-2ndset-1.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775100#action_12775100 ]
Michael Greene commented on CASSANDRA-338:
------------------------------------------
I have another round of a few that we can add in, but after that I
think it should. There are always going to be small things to fix
that can be found by static analysis, but most of the things it picks
up now are out of our control.
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Assignee: Michael Greene
> Priority: Trivial
> Attachments: CASSANDRA-338-CCE.diff, cassandra-findbugs-1.diff, cassandra-findbugs-2.diff, findbugs-2nd-addendum.diff, findbugs-2ndset-1.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738949#action_12738949 ]
Hudson commented on CASSANDRA-338:
----------------------------------
Integrated in Cassandra #157 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/157/])
brings findbugs count from 266 -> 250 bugs by fixing some scopes, removing some dead code, and not implementing Serializable unnecessarily. patch by Michael Greene; reviewed for by jbellis
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: cassandra-findbugs-1.diff, cassandra-findbugs-2.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739491#action_12739491 ]
Jonathan Ellis commented on CASSANDRA-338:
------------------------------------------
committed
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: cassandra-findbugs-1.diff, cassandra-findbugs-2.diff, findbugs-2nd-addendum.diff, findbugs-2ndset-1.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-338:
-------------------------------------
Attachment: cassandra-findbugs-2.diff
Incorporates jbellis's more rational way of solving the Row serialization problem.
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: cassandra-findbugs-1.diff, cassandra-findbugs-2.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Bill de hOra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill de hOra updated CASSANDRA-338:
-----------------------------------
Attachment: CASSANDRA-338-CCE.diff
Fixes two bad classcasts in StorageService.
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: CASSANDRA-338-CCE.diff, cassandra-findbugs-1.diff, cassandra-findbugs-2.diff, findbugs-2nd-addendum.diff, findbugs-2ndset-1.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Bill de hOra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill de hOra updated CASSANDRA-338:
-----------------------------------
Attachment: (was: CASSANDRA-338-CCE.diff)
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: cassandra-findbugs-1.diff, cassandra-findbugs-2.diff, findbugs-2nd-addendum.diff, findbugs-2ndset-1.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738547#action_12738547 ]
Jonathan Ellis commented on CASSANDRA-338:
------------------------------------------
why make Row serializable?
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: cassandra-findbugs-1.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739127#action_12739127 ]
Jonathan Ellis commented on CASSANDRA-338:
------------------------------------------
(does that resolve this issue?)
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: cassandra-findbugs-1.diff, cassandra-findbugs-2.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739134#action_12739134 ]
Michael Greene commented on CASSANDRA-338:
------------------------------------------
Well, there are plenty of other ones to pick off in the report. I'd rather keep this open until we're planning on wrapping up 0.4 rather than open up new issues for each set. I have 2 more off the 250 in a local branch.
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: cassandra-findbugs-1.diff, cassandra-findbugs-2.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-338) Fix low-hanging scoping and other
issues picked up by findbugs
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-338:
-------------------------------------
Attachment: cassandra-findbugs-1.diff
Attached patch brings count from 266 -> 250 bugs by fixing some scopes, removing some dead code, and properly implementing Serializable
> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
> Key: CASSANDRA-338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: Michael Greene
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: cassandra-findbugs-1.diff
>
>
> Findbugs currently reports 266 bugs against trunk. Many of these are invalid, but many are genuine. This issue will involve fixing the genuine ones that are fixable in time for 0.4.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.