You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/05/16 06:23:30 UTC
[GitHub] [helix] alirezazamani commented on a change in pull request #1736: Properly clean up TaskCurrentState sessions
alirezazamani commented on a change in pull request #1736:
URL: https://github.com/apache/helix/pull/1736#discussion_r633049345
##########
File path: helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java
##########
@@ -362,6 +363,7 @@ private void carryOverPreviousCurrentState() {
}
// If the the current state is related to tasks, there is no need to carry it over to new session.
+ // Note: this check is not necessary due to TaskCurrentStates, but keep it for backwards compatibility
Review comment:
I am not sure if I understand this comment. We have this check to not carry over task related current states. Why it is not necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org