[jira] [Resolved] (HADOOP-18364) All method metrics related to the RPC protocol should be initialized

["Xiaoqiao He (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-18364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xiaoqiao He resolved HADOOP-18364.
----------------------------------
    Fix Version/s: 3.4.0
     Hadoop Flags: Reviewed
       Resolution: Fixed

Committed to trunk. Thanks [~zhangshuyan] for your contribution. Please let me know if you want to backport to other active branches.

> All method metrics related to the RPC protocol should be initialized
> --------------------------------------------------------------------
>
>                 Key: HADOOP-18364
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18364
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Shuyan Zhang
>            Assignee: Shuyan Zhang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.4.0
>
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> When an RPC protocol is used, the metric of protocol-related methods should be initialized; otherwise, metric information will be incomplete. For example, when we call HAServiceProtocol#monitorHealth(), only the metric of monitorHealth() are initialized, and the metric of transitionToStandby() are still not reported. This incompleteness caused a little trouble for our monitoring system.
> The root cause is that the parameter passed by RpcEngine to MutableRatesWithAggregation#init(java.lang.Class<?>)  is always XXXProtocolPB, which is inherited from BlockingInterface and does not implement any methods. We should fix this bug.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org