[GitHub] [metron] mmiklavc commented on a change in pull request #1400: METRON-2106: Escalation topic setting in Ambari has no effect

[GitBox <gi...@apache.org>]

mmiklavc commented on a change in pull request #1400: METRON-2106: Escalation topic setting in Ambari has no effect
URL: https://github.com/apache/metron/pull/1400#discussion_r282547854
 
 

 ##########
 File path: metron-interface/metron-rest/src/main/scripts/metron-rest.sh
 ##########
 @@ -83,7 +83,7 @@ echo "METRON_SPRING_PROFILES_ACTIVE=${METRON_SPRING_PROFILES_ACTIVE}"
 
 # the vagrant Spring profile provides configuration values, otherwise configuration is provided by rest_application.yml
 if [[ !(${METRON_SPRING_PROFILES_ACTIVE} == *"vagrant"*) ]]; then
-    METRON_CONFIG_LOCATION=" --spring.config.location=$METRON_HOME/config/rest_application.yml,classpath:/application.yml"
 
 Review comment:
   The ordering/appending via `--spring.config.additional-location` makes sense. But I see you've removed `classpath:/application.yml` altogether. Was that intentional? How is application.yml loaded now, or is it not needed at all?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services