You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "NextbrickInc (via GitHub)" <gi...@apache.org> on 2026/08/21 01:01:14 UTC
[PR] GITHUB#13829: Scale TestRuleLimitSysouts limits by tests.iters [lucene]
NextbrickInc opened a new pull request, #16541:
URL: https://github.com/apache/lucene/pull/16541
## Summary
- Fixes https://github.com/apache/lucene/issues/13829
- Multiply the per-suite sysout byte budget by `tests.iters` so suites that print a modest amount per iteration no longer fail when rerun.
- Adds a nested regression test and a CHANGES.txt entry.
## Test plan
- [x] `./gradlew :lucene:test-framework:test --tests org.apache.lucene.tests.util.TestSysoutsLimits`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] GITHUB#13829: Scale TestRuleLimitSysouts limits by tests.iters [lucene]
Posted by "NextbrickInc (via GitHub)" <gi...@apache.org>.
NextbrickInc commented on PR #16541:
URL: https://github.com/apache/lucene/pull/16541#issuecomment-5424719909
Understood, thanks for clarifying. Since #16535 already implements the intended behavior, I’ll close this follow-up.
Let me know if you need anything else @msokolov . Im available for bug fixing testing. Scalable, reliable Testing. @erikhatcher
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] GITHUB#13829: Scale TestRuleLimitSysouts limits by tests.iters [lucene]
Posted by "NextbrickInc (via GitHub)" <gi...@apache.org>.
NextbrickInc closed pull request #16541: GITHUB#13829: Scale TestRuleLimitSysouts limits by tests.iters
URL: https://github.com/apache/lucene/pull/16541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] GITHUB#13829: Scale TestRuleLimitSysouts limits by tests.iters [lucene]
Posted by "NextbrickInc (via GitHub)" <gi...@apache.org>.
NextbrickInc commented on PR #16541:
URL: https://github.com/apache/lucene/pull/16541#issuecomment-5422783217
@dweiss This is a focused follow-up to #16535: instead of disabling sysout enforcement for repeated tests, it keeps enforcement and scales the soft budget by `tests.iters`. The focused suite passes all 5 tests and Google Java format passes. I would appreciate your view on whether preserving that protection is worthwhile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] GITHUB#13829: Scale TestRuleLimitSysouts limits by tests.iters [lucene]
Posted by "msokolov (via GitHub)" <gi...@apache.org>.
msokolov commented on PR #16541:
URL: https://github.com/apache/lucene/pull/16541#issuecomment-5423892825
I don't think we need this. Checking the length of single runs' output is enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] GITHUB#13829: Scale TestRuleLimitSysouts limits by tests.iters [lucene]
Posted by "NextbrickInc (via GitHub)" <gi...@apache.org>.
NextbrickInc commented on PR #16541:
URL: https://github.com/apache/lucene/pull/16541#issuecomment-5431338147
Thanks for the explanation—that makes sense. The limit is intended to catch accidental leftover debugging output in normal single runs, while intentionally multiplied test runs should not be constrained by the accumulated output. Closing this was the right approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] GITHUB#13829: Scale TestRuleLimitSysouts limits by tests.iters [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #16541:
URL: https://github.com/apache/lucene/pull/16541#issuecomment-5430193760
> I don't think we need this. Checking the length of single runs' output is enough
Precisely. If somebody multiplies tests, they probably know what they're doing - it doesn't matter that a test exceeds the limits then. These checks are to keep leftover debugging from proliferating in the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org