You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Peter Schuller (Created) (JIRA)" <ji...@apache.org> on 2012/03/28 05:15:22 UTC
[jira] [Created] (CASSANDRA-4096) mlockall() returned code is
ignored w/o assertions
mlockall() returned code is ignored w/o assertions
--------------------------------------------------
Key: CASSANDRA-4096
URL: https://issues.apache.org/jira/browse/CASSANDRA-4096
Project: Cassandra
Issue Type: Bug
Components: Core
Reporter: Peter Schuller
We log that mlockall() was successful only based on the lack of an assertion failure, so for anyone running w/o {{-ea}} we are lying about mlockall() succeeding.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4096) mlockall() returned code is
ignored w/o assertions
Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-4096:
--------------------------------------
Attachment: 4096.txt
The assert is redundant anyway since JNA will check return value and errno for us. Patch attached.
> mlockall() returned code is ignored w/o assertions
> --------------------------------------------------
>
> Key: CASSANDRA-4096
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4096
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Peter Schuller
> Labels: jna
> Attachments: 4096.txt
>
>
> We log that mlockall() was successful only based on the lack of an assertion failure, so for anyone running w/o {{-ea}} we are lying about mlockall() succeeding.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4096) mlockall() returned code is
ignored w/o assertions
Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-4096:
--------------------------------------
Reviewer: scode
Priority: Minor (was: Major)
Assignee: Jonathan Ellis
Labels: jna (was: )
> mlockall() returned code is ignored w/o assertions
> --------------------------------------------------
>
> Key: CASSANDRA-4096
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4096
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Peter Schuller
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: jna
> Attachments: 4096.txt
>
>
> We log that mlockall() was successful only based on the lack of an assertion failure, so for anyone running w/o {{-ea}} we are lying about mlockall() succeeding.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4096) mlockall() returned code is
ignored w/o assertions
Posted by "Peter Schuller (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242017#comment-13242017 ]
Peter Schuller commented on CASSANDRA-4096:
-------------------------------------------
Good point. If that's the behavior of JNA, then definitely +1.
> mlockall() returned code is ignored w/o assertions
> --------------------------------------------------
>
> Key: CASSANDRA-4096
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4096
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Peter Schuller
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: jna
> Attachments: 4096.txt
>
>
> We log that mlockall() was successful only based on the lack of an assertion failure, so for anyone running w/o {{-ea}} we are lying about mlockall() succeeding.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira