You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Leif Hedstrom (JIRA)" <ji...@apache.org> on 2010/08/24 19:45:20 UTC
[jira] Created: (TS-424) DNS max-retries inconsistencies
DNS max-retries inconsistencies
-------------------------------
Key: TS-424
URL: https://issues.apache.org/jira/browse/TS-424
Project: Traffic Server
Issue Type: Bug
Components: DNS
Reporter: Leif Hedstrom
While examining some related code, I noticed a few inconsistencies with our max-retries / default-retries code. In RecordsConfig.cc we have
{CONFIG, "proxy.config.dns.retries", "", INK_INT, "5", RU_REREAD, RR_NULL, RC_NULL, NULL, RA_NULL}
while in the iocore/dns code, we have
iocore/dns/P_DNSProcessor.h: #define DEFAULT_DNS_RETRIES 3
(the former overrides the latter though, but still confusing). Additionally, we have a define
iocore/dns/P_DNSProcessor.h: #define MAX_DNS_RETRIES 5
which dictates the size of at least one static array. A problem here would be if someone tried to set proxy.config.dns.retries above 5, we might do bad things.
At a minimum, proxy.config.dns.retries should be capped to MAX_DNS_RETRIES (this can be done in RecordsConfig.cc), and DEFAULT_DNS_RETRIES should have the same default as the RecordsConfig.cc setting (for consistency). We might want to bump up MAX_DNS_RETRIES too maybe to 9 (or 11), or possibly make the static arrays dynamically allocated (not sure that's worth the cost though, really).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TS-424) DNS max-retries inconsistencies
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom resolved TS-424.
------------------------------
Resolution: Fixed
Fixed.
> DNS max-retries inconsistencies
> -------------------------------
>
> Key: TS-424
> URL: https://issues.apache.org/jira/browse/TS-424
> Project: Traffic Server
> Issue Type: Bug
> Components: DNS
> Reporter: Leif Hedstrom
> Fix For: 2.1.3
>
>
> While examining some related code, I noticed a few inconsistencies with our max-retries / default-retries code. In RecordsConfig.cc we have
> {CONFIG, "proxy.config.dns.retries", "", INK_INT, "5", RU_REREAD, RR_NULL, RC_NULL, NULL, RA_NULL}
> while in the iocore/dns code, we have
> iocore/dns/P_DNSProcessor.h: #define DEFAULT_DNS_RETRIES 3
> (the former overrides the latter though, but still confusing). Additionally, we have a define
> iocore/dns/P_DNSProcessor.h: #define MAX_DNS_RETRIES 5
> which dictates the size of at least one static array. A problem here would be if someone tried to set proxy.config.dns.retries above 5, we might do bad things.
> At a minimum, proxy.config.dns.retries should be capped to MAX_DNS_RETRIES (this can be done in RecordsConfig.cc), and DEFAULT_DNS_RETRIES should have the same default as the RecordsConfig.cc setting (for consistency). We might want to bump up MAX_DNS_RETRIES too maybe to 9 (or 11), or possibly make the static arrays dynamically allocated (not sure that's worth the cost though, really).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-424) DNS max-retries inconsistencies
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-424:
-----------------------------
Fix Version/s: 2.1.3
> DNS max-retries inconsistencies
> -------------------------------
>
> Key: TS-424
> URL: https://issues.apache.org/jira/browse/TS-424
> Project: Traffic Server
> Issue Type: Bug
> Components: DNS
> Reporter: Leif Hedstrom
> Fix For: 2.1.3
>
>
> While examining some related code, I noticed a few inconsistencies with our max-retries / default-retries code. In RecordsConfig.cc we have
> {CONFIG, "proxy.config.dns.retries", "", INK_INT, "5", RU_REREAD, RR_NULL, RC_NULL, NULL, RA_NULL}
> while in the iocore/dns code, we have
> iocore/dns/P_DNSProcessor.h: #define DEFAULT_DNS_RETRIES 3
> (the former overrides the latter though, but still confusing). Additionally, we have a define
> iocore/dns/P_DNSProcessor.h: #define MAX_DNS_RETRIES 5
> which dictates the size of at least one static array. A problem here would be if someone tried to set proxy.config.dns.retries above 5, we might do bad things.
> At a minimum, proxy.config.dns.retries should be capped to MAX_DNS_RETRIES (this can be done in RecordsConfig.cc), and DEFAULT_DNS_RETRIES should have the same default as the RecordsConfig.cc setting (for consistency). We might want to bump up MAX_DNS_RETRIES too maybe to 9 (or 11), or possibly make the static arrays dynamically allocated (not sure that's worth the cost though, really).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.