You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@samza.apache.org by nickpan47 <gi...@git.apache.org> on 2018/08/31 21:15:28 UTC

[GitHub] samza pull request #620: Samza 1836: StreamManager created before ExecutionP...

GitHub user nickpan47 opened a pull request:

    https://github.com/apache/samza/pull/620

    Samza 1836: StreamManager created before ExecutionPlanner should also apply configuration overrides

    Our integration test framework uses configuration overrides (i.e. jobs.*) to override the user system configuration set in the code (e.g. KafkaSystemDescriptor) to test systems. However, the StreamManager we created before calling ExecutionPlanner.plan() does not apply the overrides and causes failure in tests since the system was not correctly set to in-memory systems by configuration overrides.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nickpan47/samza SAMZA-1836

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/620.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #620
    
----
commit 35f2c0b7aa14ec28df6c02d4dd5fa953ef6666a3
Author: Yi Pan (Data Infrastructure) <ni...@...>
Date:   2018-08-31T18:30:38Z

    SAMZA-1836: fixing two unit tests that should use InMemorySystemFactory instead of KafkaSystemDescriptor

commit a376b88808d154afd47b29e468f7a9030623afc6
Author: Yi Pan (Data Infrastructure) <ni...@...>
Date:   2018-08-31T21:10:11Z

    SAMZA-1836: StreamManager created before ExecutionPlanner should also apply the configuration overrides

----


---

[GitHub] samza pull request #620: Samza 1836: StreamManager created before ExecutionP...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/samza/pull/620


---