[GitHub] [hbase] saintstack commented on a change in pull request #1305: HBASE-23984 [Flakey Tests] TestMasterAbortAndRSGotKilled fails in tea…

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #1305: HBASE-23984 [Flakey Tests] TestMasterAbortAndRSGotKilled fails in tea…
URL: https://github.com/apache/hbase/pull/1305#discussion_r394703158
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
 ##########
 @@ -3185,71 +3195,61 @@ private void closeRegionIgnoreErrors(RegionInfo region, final boolean abort) {
    *   If a close was in progress, this new request will be ignored, and an exception thrown.
    * </p>
    *
-   * @param encodedName Region to close
    * @param abort True if we are aborting
+   * @param destination Where the Region is being moved too... maybe null if unknown.
    * @return True if closed a region.
    * @throws NotServingRegionException if the region is not online
    */
-  protected boolean closeRegion(String encodedName, final boolean abort, final ServerName sn)
-      throws NotServingRegionException {
-    //Check for permissions to close.
-    HRegion actualRegion = this.getRegion(encodedName);
-    // Can be null if we're calling close on a region that's not online
-    if ((actualRegion != null) && (actualRegion.getCoprocessorHost() != null)) {
-      try {
-        actualRegion.getCoprocessorHost().preClose(false);
-      } catch (IOException exp) {
-        LOG.warn("Unable to close region: the coprocessor launched an error ", exp);
-        return false;
-      }
-    }
-
-    // previous can come back 'null' if not in map.
-    final Boolean previous = this.regionsInTransitionInRS.putIfAbsent(Bytes.toBytes(encodedName),
-        Boolean.FALSE);
-
+  protected boolean closeRegion(String encodedRegionName, final boolean abort,
+      @Nullable final ServerName destination) throws NotServingRegionException {
 
 Review comment:
   Let me remove.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services