[jira] [Commented] (KYLIN-3481) Kylin Jdbc: Shaded dependencies should not be transitive

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567752#comment-16567752 ] 

ASF GitHub Bot commented on KYLIN-3481:
---------------------------------------

asfgit commented on issue #185: KYLIN-3481 Shaded dependencies should be optional
URL: https://github.com/apache/kylin/pull/185#issuecomment-410140345
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Kylin Jdbc: Shaded dependencies should not be transitive
> --------------------------------------------------------
>
>                 Key: KYLIN-3481
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3481
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Driver - JDBC
>    Affects Versions: v2.4.0
>            Reporter: Ian Hu
>            Assignee: Ian Hu
>            Priority: Major
>
> kylin-jdbc use dependencies as shaded, so they should not be transitive.
> As far as I known, SHADE a dependency to avoid dependency conflict, but at v2.4.0, the dependencies in kylin-jdbc are default compile scope and are transitive resolved, that may cause some dependency conflicts.
> We should mark shaded dependencies as optional



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)