You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2017/06/24 18:57:58 UTC
[kudu-CR] [java] remove unused scalamock dependency
Grant Henke has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7292
Change subject: [java] remove unused scalamock dependency
......................................................................
[java] remove unused scalamock dependency
Change-Id: I97005bd5211abd0b119373ec265b8e9d01b385cf
---
M java/kudu-spark-tools/pom.xml
1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/7292/1
--
To view, visit http://gerrit.cloudera.org:8080/7292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I97005bd5211abd0b119373ec265b8e9d01b385cf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
[kudu-CR] [java] remove unused scalamock dependency
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [java] remove unused scalamock dependency
......................................................................
Patch Set 1:
ah sorry I think I merged in the wrong order
--
To view, visit http://gerrit.cloudera.org:8080/7292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I97005bd5211abd0b119373ec265b8e9d01b385cf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [java] remove unused scalamock dependency
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change.
Change subject: [java] remove unused scalamock dependency
......................................................................
Patch Set 2:
No, thats my fault. I made the patches all separate in case on took longer to review. So no matter what order you took there would have been a merge issue.
Fixed now.
--
To view, visit http://gerrit.cloudera.org:8080/7292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I97005bd5211abd0b119373ec265b8e9d01b385cf
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [java] remove unused scalamock dependency
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [java] remove unused scalamock dependency
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I97005bd5211abd0b119373ec265b8e9d01b385cf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [java] remove unused scalamock dependency
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: [java] remove unused scalamock dependency
......................................................................
[java] remove unused scalamock dependency
Change-Id: I97005bd5211abd0b119373ec265b8e9d01b385cf
Reviewed-on: http://gerrit.cloudera.org:8080/7292
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M java/kudu-spark-tools/pom.xml
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I97005bd5211abd0b119373ec265b8e9d01b385cf
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java] remove unused scalamock dependency
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [java] remove unused scalamock dependency
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I97005bd5211abd0b119373ec265b8e9d01b385cf
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [java] remove unused scalamock dependency
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7292
to look at the new patch set (#2).
Change subject: [java] remove unused scalamock dependency
......................................................................
[java] remove unused scalamock dependency
Change-Id: I97005bd5211abd0b119373ec265b8e9d01b385cf
---
M java/kudu-spark-tools/pom.xml
1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/7292/2
--
To view, visit http://gerrit.cloudera.org:8080/7292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I97005bd5211abd0b119373ec265b8e9d01b385cf
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins