[GitHub] [airflow] eladkal commented on a change in pull request #16115: Add support for extra parameters to samba client

[GitBox <gi...@apache.org>]

eladkal commented on a change in pull request #16115:
URL: https://github.com/apache/airflow/pull/16115#discussion_r644525992



##########
File path: airflow/providers/samba/hooks/samba.py
##########
@@ -36,12 +36,26 @@ def __init__(self, samba_conn_id: str = default_conn_name) -> None:
         self.conn = self.get_connection(samba_conn_id)
 
     def get_conn(self) -> SambaClient:
+        """
+        Return a samba client object.
+
+        You can provide optional parameters in the extra fields of
+        your connection.
+
+        :param logdir: Base directory name for log/debug files.
+        :param kerberos: Try to authenticate with kerberos.
+        :param workgroup: Set the SMB domain of the username.
+        :param netbios_name:
+            This option allows you to override the NetBIOS name that
+            Samba uses for itself.
+        """
         samba = SambaClient(
             server=self.conn.host,
             share=self.conn.schema,
             username=self.conn.login,
             ip=self.conn.host,
             password=self.conn.password,
+            **self.conn.extra_dejson,

Review comment:
       @malthe 
   Can you please rebase to latest master?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org