You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/14 02:54:23 UTC

[GitHub] [dolphinscheduler] KINGGUOKUN opened a new issue, #12370: [Bug] [Module Name] Bug title

KINGGUOKUN opened a new issue, #12370:
URL: https://github.com/apache/dolphinscheduler/issues/12370

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What happened
   
   带自定义参数的SQL任务类型，创建定时调度，底层出现调度流参数空，如果不采用定时调度，手动运行，可以正常执行SQL类型工作流。
   具体异常信息如下：
    TaskLogLogger-class org.apache.dolphinscheduler.server.master.runner.task.CommonTaskProcessor:[125] - [WorkflowInstance-54][TaskInstance-0] - submit task error
   java.lang.NullPointerException: Cannot invoke "java.util.Map.get(Object)" because "cmdParam" is null
           at org.apache.dolphinscheduler.service.expand.CuringGlobalParams.paramParsingPreparation(CuringGlobalParams.java:154)
           at org.apache.dolphinscheduler.server.master.runner.task.BaseTaskProcessor.getTaskExecutionContext(BaseTaskProcessor.java:336)
           at org.apache.dolphinscheduler.server.master.runner.task.CommonTaskProcessor.dispatchTask(CommonTaskProcessor.java:113)
           at org.apache.dolphinscheduler.server.master.runner.task.BaseTaskProcessor.dispatch(BaseTaskProcessor.java:241)
           at org.apache.dolphinscheduler.server.master.runner.task.BaseTaskProcessor.action(BaseTaskProcessor.java:212)
           at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteRunnable.submitTaskExec(WorkflowExecuteRunnable.java:976)
           at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteRunnable.submitStandByTask(WorkflowExecuteRunnable.java:1816)
           at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteRunnable.submitPostNode(WorkflowExecuteRunnable.java:1349)
           at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteRunnable.call(WorkflowExecuteRunnable.java:695)
           at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768)
           at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
           at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
           at java.base/java.lang.Thread.run(Thread.java:1589)
   
   ### What you expected to happen
   
   针对带自定义参数的SQL任务类型，创建定时调度可以成功运行。
   
   ### How to reproduce
   
   1、创建工作流定义；
   2、拖入SQL任务类型，设置自定义参数并在SQL文本中引用；
   3、保存工作流定义；
   4、创建定时调度；
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   3.1.x
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] KINGGUOKUN commented on issue #12370: [Bug] [Module Name] Bug title

Posted by GitBox <gi...@apache.org>.
KINGGUOKUN commented on issue #12370:
URL: https://github.com/apache/dolphinscheduler/issues/12370#issuecomment-1278439316

   > English is needed, please add the title and update content
   
   Thanks for your reply. I have update the content, please review again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhuangchong commented on issue #12370: Schedulered process with custom params fails

Posted by GitBox <gi...@apache.org>.
zhuangchong commented on issue #12370:
URL: https://github.com/apache/dolphinscheduler/issues/12370#issuecomment-1283434422

   I understand your question is the same issue as this issue #12408, which has been fixed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] KINGGUOKUN commented on issue #12370: Schedulered process with custom params fails

Posted by GitBox <gi...@apache.org>.
KINGGUOKUN commented on issue #12370:
URL: https://github.com/apache/dolphinscheduler/issues/12370#issuecomment-1280117020

   ![image](https://user-images.githubusercontent.com/12315104/196067466-ac185ec6-ca1b-4424-b11e-13a22402902b.png)
   
   And do add cron based scheduler to the process.
   ![image](https://user-images.githubusercontent.com/12315104/196067552-6dad54d4-e201-49cc-badc-3fcb69c53553.png)
   
   Then the result like this:
   ![image](https://user-images.githubusercontent.com/12315104/196067688-e9425eaa-ec8a-4212-8b24-aed836a71ff7.png)
   ![image](https://user-images.githubusercontent.com/12315104/196067711-18846caa-dc77-425f-871c-13e734e6c3ad.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] KINGGUOKUN closed issue #12370: Schedulered process with custom params fails

Posted by GitBox <gi...@apache.org>.
KINGGUOKUN closed issue #12370: Schedulered process with custom params fails
URL: https://github.com/apache/dolphinscheduler/issues/12370


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #12370: [Bug] [Module Name] Bug title

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #12370:
URL: https://github.com/apache/dolphinscheduler/issues/12370#issuecomment-1278407077

   Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
   * In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
   * If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #12370: [Bug] [Module Name] Bug title

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #12370:
URL: https://github.com/apache/dolphinscheduler/issues/12370#issuecomment-1278406913

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What happened
   
   For the SQL task type with custom parameters, create a scheduled schedule, and the underlying scheduling flow parameter is empty. If you do not use scheduled scheduling and run it manually, the SQL type workflow can be executed normally.
   The specific exception information is as follows:
    TaskLogLogger-class org.apache.dolphinscheduler.server.master.runner.task.CommonTaskProcessor:[125] - [WorkflowInstance-54][TaskInstance-0] - submit task error
   java.lang.NullPointerException: Cannot invoke "java.util.Map.get(Object)" because "cmdParam" is null
           at org.apache.dolphinscheduler.service.expand.CuringGlobalParams.paramParsingPreparation(CuringGlobalParams.java:154)
           at org.apache.dolphinscheduler.server.master.runner.task.BaseTaskProcessor.getTaskExecutionContext(BaseTaskProcessor.java:336)
           at org.apache.dolphinscheduler.server.master.runner.task.CommonTaskProcessor.dispatchTask(CommonTaskProcessor.java:113)
           at org.apache.dolphinscheduler.server.master.runner.task.BaseTaskProcessor.dispatch(BaseTaskProcessor.java:241)
           at org.apache.dolphinscheduler.server.master.runner.task.BaseTaskProcessor.action(BaseTaskProcessor.java:212)
           at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteRunnable.submitTaskExec(WorkflowExecuteRunnable.java:976)
           at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteRunnable.submitStandByTask(WorkflowExecuteRunnable.java:1816)
           at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteRunnable.submitPostNode(WorkflowExecuteRunnable.java:1349)
           at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteRunnable.call(WorkflowExecuteRunnable.java:695)
           at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768)
           at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
           at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
           at java.base/java.lang.Thread.run(Thread.java:1589)
   
   ### What you expected to happen
   
   For SQL task types with custom parameters, creating a scheduled schedule can run successfully.
   
   ### How to reproduce
   
   1. Create a workflow definition;
   2. Drag in the SQL task type, set custom parameters and quote them in the SQL text;
   3. Save the workflow definition;
   4. Create timing schedule;
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   3.1.x
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] davidzollo commented on issue #12370: [Bug] [Module Name] Bug title

Posted by GitBox <gi...@apache.org>.
davidzollo commented on issue #12370:
URL: https://github.com/apache/dolphinscheduler/issues/12370#issuecomment-1278420278

   English is needed, update the title and content


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] hstdream commented on issue #12370: Schedulered process with custom params fails

Posted by GitBox <gi...@apache.org>.
hstdream commented on issue #12370:
URL: https://github.com/apache/dolphinscheduler/issues/12370#issuecomment-1278687693

   <img width="446" alt="1665736953404" src="https://user-images.githubusercontent.com/33045461/195803289-60c11410-a34d-4124-8bdd-76b7f6565056.png">
   <img width="572" alt="1665737023343" src="https://user-images.githubusercontent.com/33045461/195803558-cc067c19-4a7d-4861-b83a-6458b2fcd3e1.png">
   
   I didn't find any problems here. It is recommended to provide the following specific operation steps. thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] KINGGUOKUN commented on issue #12370: Schedulered process with custom params fails

Posted by GitBox <gi...@apache.org>.
KINGGUOKUN commented on issue #12370:
URL: https://github.com/apache/dolphinscheduler/issues/12370#issuecomment-1283473433

   Yes, exactly. So, I'll close it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org