[GitHub] [iceberg] rdblue commented on a diff in pull request #6775: Python: Add positional deletes

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on code in PR #6775:
URL: https://github.com/apache/iceberg/pull/6775#discussion_r1110326123


##########
python/pyiceberg/table/__init__.py:
##########
@@ -374,7 +358,6 @@ def plan_files(self) -> Iterator[FileScanTask]:
 
         # step 2: filter the data files in each manifest
         # this filter depends on the partition spec used to write the manifest file
-

Review Comment:
   Nit: unnecessary whitespace change.



##########
python/tests/io/test_pyarrow.py:
##########
@@ -377,7 +378,7 @@ def test_timestamp_type_to_pyarrow() -> None:
 
 def test_timestamptz_type_to_pyarrow() -> None:
     iceberg_type = TimestamptzType()
-    assert visit(iceberg_type, _ConvertToArrowSchema()) == pa.timestamp(unit="us", tz="+00:00")
+    assert visit(iceberg_type, _ConvertToArrowSchema()) == pa.timestamp(unit="us", tz="UTC")

Review Comment:
   Why are these changes needed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org