You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Adam Kramer (Created) (JIRA)" <ji...@apache.org> on 2011/10/04 02:11:33 UTC
[jira] [Created] (HIVE-2477) Use name of original expression for
name of CAST output
Use name of original expression for name of CAST output
-------------------------------------------------------
Key: HIVE-2477
URL: https://issues.apache.org/jira/browse/HIVE-2477
Project: Hive
Issue Type: Improvement
Reporter: Adam Kramer
Priority: Minor
CAST(foo AS INT)
should, by default, consider itself a column named foo if unspecified/unaliased.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2477) Use name of original expression for
name of CAST output
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2477:
------------------------------
Attachment: HIVE-2477.D7161.2.patch
navis updated the revision "HIVE-2477 [jira] Use name of original expression for name of CAST output".
Reviewers: JIRA
Addressed comments
REVISION DETAIL
https://reviews.facebook.net/D7161
AFFECTED FILES
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java
ql/src/test/queries/clientpositive/alias_casted_column.q
ql/src/test/results/clientpositive/alias_casted_column.q.out
ql/src/test/results/compiler/plan/input_testxpath2.q.xml
To: JIRA, navis
Cc: njain
> Use name of original expression for name of CAST output
> -------------------------------------------------------
>
> Key: HIVE-2477
> URL: https://issues.apache.org/jira/browse/HIVE-2477
> Project: Hive
> Issue Type: Improvement
> Reporter: Adam Kramer
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2477.1.patch.txt, HIVE-2477.D7161.1.patch, HIVE-2477.D7161.2.patch
>
>
> CAST(foo AS INT)
> should, by default, consider itself a column named foo if unspecified/unaliased.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2477) Use name of original expression for
name of CAST output
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2477:
------------------------------
Attachment: HIVE-2477.D7161.1.patch
navis requested code review of "HIVE-2477 [jira] Use name of original expression for name of CAST output".
Reviewers: JIRA
DPAL-642 Use name of original expression for name of CAST output
CAST(foo AS INT)
should, by default, consider itself a column named foo if unspecified/unaliased.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D7161
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
ql/src/test/queries/clientpositive/alias_casted_column.q
ql/src/test/queries/clientpositive/alias_unary_function.q
ql/src/test/results/clientpositive/alias_unary_function.q.out
ql/src/test/results/compiler/plan/input_testxpath2.q.xml
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/16953/
To: JIRA, navis
> Use name of original expression for name of CAST output
> -------------------------------------------------------
>
> Key: HIVE-2477
> URL: https://issues.apache.org/jira/browse/HIVE-2477
> Project: Hive
> Issue Type: Improvement
> Reporter: Adam Kramer
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2477.1.patch.txt, HIVE-2477.D7161.1.patch
>
>
> CAST(foo AS INT)
> should, by default, consider itself a column named foo if unspecified/unaliased.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2477) Use name of original expression for
name of CAST output
Posted by "Navis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Navis updated HIVE-2477:
------------------------
Attachment: HIVE-2477.1.patch.txt
Simple patch.
If a column is function with single param and the param is a column, use the column name as alias.
> Use name of original expression for name of CAST output
> -------------------------------------------------------
>
> Key: HIVE-2477
> URL: https://issues.apache.org/jira/browse/HIVE-2477
> Project: Hive
> Issue Type: Improvement
> Reporter: Adam Kramer
> Priority: Minor
> Attachments: HIVE-2477.1.patch.txt
>
>
> CAST(foo AS INT)
> should, by default, consider itself a column named foo if unspecified/unaliased.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2477) Use name of original expression for
name of CAST output
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511082#comment-13511082 ]
Phabricator commented on HIVE-2477:
-----------------------------------
njain has commented on the revision "HIVE-2477 [jira] Use name of original expression for name of CAST output".
minor comments
INLINE COMMENTS
ql/src/test/queries/clientpositive/alias_casted_column.q:1 you forgot to add the output file for this
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1185 do you want to add a indirection ?
something like:
isOpPreserveInputName() -- which can call isOpCast (isOpCast can be private).
and the caller (SemanticAnalyzer can call isOpPreserveName). If in future there
is another function with this requirement, it would be easy.
REVISION DETAIL
https://reviews.facebook.net/D7161
To: JIRA, navis
Cc: njain
> Use name of original expression for name of CAST output
> -------------------------------------------------------
>
> Key: HIVE-2477
> URL: https://issues.apache.org/jira/browse/HIVE-2477
> Project: Hive
> Issue Type: Improvement
> Reporter: Adam Kramer
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2477.1.patch.txt, HIVE-2477.D7161.1.patch
>
>
> CAST(foo AS INT)
> should, by default, consider itself a column named foo if unspecified/unaliased.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-2477) Use name of original expression for
name of CAST output
Posted by "Navis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Navis reassigned HIVE-2477:
---------------------------
Assignee: Navis
> Use name of original expression for name of CAST output
> -------------------------------------------------------
>
> Key: HIVE-2477
> URL: https://issues.apache.org/jira/browse/HIVE-2477
> Project: Hive
> Issue Type: Improvement
> Reporter: Adam Kramer
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2477.1.patch.txt
>
>
> CAST(foo AS INT)
> should, by default, consider itself a column named foo if unspecified/unaliased.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2477) Use name of original expression for
name of CAST output
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511192#comment-13511192 ]
Phabricator commented on HIVE-2477:
-----------------------------------
navis has commented on the revision "HIVE-2477 [jira] Use name of original expression for name of CAST output".
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1185 Seemed reasonable. I'll do that.
ql/src/test/queries/clientpositive/alias_casted_column.q:1 Sorry
REVISION DETAIL
https://reviews.facebook.net/D7161
To: JIRA, navis
Cc: njain
> Use name of original expression for name of CAST output
> -------------------------------------------------------
>
> Key: HIVE-2477
> URL: https://issues.apache.org/jira/browse/HIVE-2477
> Project: Hive
> Issue Type: Improvement
> Reporter: Adam Kramer
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2477.1.patch.txt, HIVE-2477.D7161.1.patch
>
>
> CAST(foo AS INT)
> should, by default, consider itself a column named foo if unspecified/unaliased.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2477) Use name of original expression for
name of CAST output
Posted by "Navis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Navis updated HIVE-2477:
------------------------
Status: Patch Available (was: Open)
> Use name of original expression for name of CAST output
> -------------------------------------------------------
>
> Key: HIVE-2477
> URL: https://issues.apache.org/jira/browse/HIVE-2477
> Project: Hive
> Issue Type: Improvement
> Reporter: Adam Kramer
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2477.1.patch.txt, HIVE-2477.D7161.1.patch
>
>
> CAST(foo AS INT)
> should, by default, consider itself a column named foo if unspecified/unaliased.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2477) Use name of original expression for
name of CAST output
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-2477:
-----------------------------
Status: Open (was: Patch Available)
minor comments on phabricator
> Use name of original expression for name of CAST output
> -------------------------------------------------------
>
> Key: HIVE-2477
> URL: https://issues.apache.org/jira/browse/HIVE-2477
> Project: Hive
> Issue Type: Improvement
> Reporter: Adam Kramer
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2477.1.patch.txt, HIVE-2477.D7161.1.patch
>
>
> CAST(foo AS INT)
> should, by default, consider itself a column named foo if unspecified/unaliased.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2477) Use name of original expression for
name of CAST output
Posted by "Navis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Navis updated HIVE-2477:
------------------------
Status: Patch Available (was: Open)
> Use name of original expression for name of CAST output
> -------------------------------------------------------
>
> Key: HIVE-2477
> URL: https://issues.apache.org/jira/browse/HIVE-2477
> Project: Hive
> Issue Type: Improvement
> Reporter: Adam Kramer
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2477.1.patch.txt, HIVE-2477.D7161.1.patch, HIVE-2477.D7161.2.patch
>
>
> CAST(foo AS INT)
> should, by default, consider itself a column named foo if unspecified/unaliased.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira