You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/08/02 17:43:26 UTC
[GitHub] [daffodil-vscode] Shanedell opened a new pull request, #249: 1.1.0-rc1 Updates
Shanedell opened a new pull request, #249:
URL: https://github.com/apache/daffodil-vscode/pull/249
1.1.0-rc1 Updates:
- Add needed language file to extension package
- This being missing is what caused the launch wizard along with other things to break
- Remove the root .vscodeignore as it is no longer needed
Closes #246
Closes #247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on a diff in pull request #249: 1.1.0-rc1 Updates
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on code in PR #249:
URL: https://github.com/apache/daffodil-vscode/pull/249#discussion_r936534181
##########
build/package/.vscodeignore:
##########
@@ -29,3 +29,4 @@
!src/omega_edit/omega_edit.js
!src/omega_edit/interface.html
!src/omega_edit/omega-edit-scala-server*.zip
+!src/language/providers/intellisense/DFDLGeneralFormat.dfdl.xsdf
Review Comment:
Is the `f` at the end of `.dfdl.xsdf` intentional? The file included with Daffodil just has ` .dfdl.xsd` extension. Is this so it doesn't conflict with what Daffodil distributes or something, or is this just a typo? It looks like the actual file does have the `f` as well as a path in `src/language/dfdl.ts`, so if this is typo we are consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #249: 1.1.0-rc1 Updates
Posted by GitBox <gi...@apache.org>.
Shanedell commented on code in PR #249:
URL: https://github.com/apache/daffodil-vscode/pull/249#discussion_r936632198
##########
build/package/.vscodeignore:
##########
@@ -29,3 +29,4 @@
!src/omega_edit/omega_edit.js
!src/omega_edit/interface.html
!src/omega_edit/omega-edit-scala-server*.zip
+!src/language/providers/intellisense/DFDLGeneralFormat.dfdl.xsdf
Review Comment:
Yeah it is a typo, but a consistent typo will fix that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #249: 1.1.0-rc1 Updates
Posted by GitBox <gi...@apache.org>.
Shanedell commented on PR #249:
URL: https://github.com/apache/daffodil-vscode/pull/249#issuecomment-1204352995
@tuxji @mbeckerle @arosien Would one of you guys be able to review this PR when you have a minute?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell merged pull request #249: 1.1.0-rc1 Updates
Posted by GitBox <gi...@apache.org>.
Shanedell merged PR #249:
URL: https://github.com/apache/daffodil-vscode/pull/249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org