You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/29 07:38:44 UTC

[GitHub] [inlong] healchow opened a new pull request, #5730: [INLONG-5729][Manager] Fix the failure of suspending or restarting the sources

healchow opened a new pull request, #5730:
URL: https://github.com/apache/inlong/pull/5730

   ### Prepare a Pull Request
   
   - Fixes #5729
   
   ### Motivation
   
   Fix the failure of suspending or restarting the sources.
   
   ### Verifying this change
   
   - [x] This change is a trivial rework/code cleanup without any test coverage.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #5730: [INLONG-5729][Manager] Fix the failure of suspending or restarting the sources

Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5730:
URL: https://github.com/apache/inlong/pull/5730#discussion_r957068029


##########
inlong-manager/manager-web/sql/apache_inlong_manager.sql:
##########
@@ -759,8 +759,8 @@ CREATE TABLE IF NOT EXISTS `group_heartbeat`
     `component`        varchar(64)  NOT NULL DEFAULT '' COMMENT 'Component name, such as: Agent, Sort...',
     `instance`         varchar(64)  NOT NULL DEFAULT '' COMMENT 'Component instance, can be ip, name...',
     `inlong_group_id`  varchar(256) NOT NULL DEFAULT '' COMMENT 'Owning inlong group id',
-    `status_heartbeat` text         DEFAULT NULL COMMENT 'Status heartbeat info',
-    `metric_heartbeat` text         DEFAULT NULL COMMENT 'Metric heartbeat info',
+    `status_heartbeat` text                  DEFAULT NULL COMMENT 'Status heartbeat info',

Review Comment:
   1. It's the IDEA auto-formated.
   2. The new format looks better: `DEFAULT` is in the same column.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] leosanqing commented on a diff in pull request #5730: [INLONG-5729][Manager] Fix the failure of suspending or restarting the sources

Posted by GitBox <gi...@apache.org>.
leosanqing commented on code in PR #5730:
URL: https://github.com/apache/inlong/pull/5730#discussion_r957053427


##########
inlong-manager/manager-web/sql/apache_inlong_manager.sql:
##########
@@ -759,8 +759,8 @@ CREATE TABLE IF NOT EXISTS `group_heartbeat`
     `component`        varchar(64)  NOT NULL DEFAULT '' COMMENT 'Component name, such as: Agent, Sort...',
     `instance`         varchar(64)  NOT NULL DEFAULT '' COMMENT 'Component instance, can be ip, name...',
     `inlong_group_id`  varchar(256) NOT NULL DEFAULT '' COMMENT 'Owning inlong group id',
-    `status_heartbeat` text         DEFAULT NULL COMMENT 'Status heartbeat info',
-    `metric_heartbeat` text         DEFAULT NULL COMMENT 'Metric heartbeat info',
+    `status_heartbeat` text                  DEFAULT NULL COMMENT 'Status heartbeat info',

Review Comment:
   Why is there indentation here, the previous format should be more standardized



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow merged pull request #5730: [INLONG-5729][Manager] Fix the failure of suspending or restarting the sources

Posted by GitBox <gi...@apache.org>.
healchow merged PR #5730:
URL: https://github.com/apache/inlong/pull/5730


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org