You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "jnh5y (via GitHub)" <gi...@apache.org> on 2023/12/05 14:29:30 UTC

Re: [PR] [FLINK-33441] Implement restore tests for ExecUnion node [flink]

jnh5y commented on code in PR #23653:
URL: https://github.com/apache/flink/pull/23653#discussion_r1415705636


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java:
##########
@@ -91,7 +91,8 @@ public EnumSet<TestKind> supportedSetupSteps() {
         return EnumSet.of(
                 TestKind.FUNCTION,
                 TestKind.SOURCE_WITH_RESTORE_DATA,
-                TestKind.SINK_WITH_RESTORE_DATA);
+                TestKind.SINK_WITH_RESTORE_DATA,
+                TestKind.SINK_WITH_DATA);

Review Comment:
   I think we can skip the changes in this file if we pass unique data in `UNION_TWO_SOURCES`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org