svn commit: r889459 [1/2] - in /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5: internal/services/SyntheticStackTraceElementAnalyzer.java services/TapestryModule.java

[hl...@apache.org]

Author: hlship
Date: Thu Dec 10 23:05:16 2009
New Revision: 889459

URL: http://svn.apache.org/viewvc?rev=889459&view=rev
Log:
TAP5-859: In a stack trace, any lines associated with line #1 of a class are likely to be synthetic methods and should be classified as "uninteresting"

Added:
    tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SyntheticStackTraceElementAnalyzer.java   (with props)
Modified:
    tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java

Added: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SyntheticStackTraceElementAnalyzer.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SyntheticStackTraceElementAnalyzer.java?rev=889459&view=auto
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SyntheticStackTraceElementAnalyzer.java (added)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SyntheticStackTraceElementAnalyzer.java Thu Dec 10 23:05:16 2009
@@ -0,0 +1,33 @@
+// Copyright 2009 The Apache Software Foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package org.apache.tapestry5.internal.services;
+
+import org.apache.tapestry5.services.StackTraceElementAnalyzer;
+import org.apache.tapestry5.services.StackTraceElementClassConstants;
+
+/**
+ * Identifies any code associated with line 1 as omitted (i.e., it's a synthetic
+ * method related to an inner class).
+ * 
+ * @since 5.2.0
+ */
+public class SyntheticStackTraceElementAnalyzer implements StackTraceElementAnalyzer
+{
+    public String classForFrame(StackTraceElement frame)
+    {
+        return frame.getLineNumber() == 1 ? StackTraceElementClassConstants.OMITTED : null;
+    }
+
+}

Propchange: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SyntheticStackTraceElementAnalyzer.java
------------------------------------------------------------------------------
    svn:eol-style = native