You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Alex Rudyy (Created) (JIRA)" <ji...@apache.org> on 2012/03/21 11:29:38 UTC

[jira] [Created] (QPID-3905) NullPointerException is thrown on rejecting messages whilst closing the connection

NullPointerException is thrown on rejecting messages whilst closing the connection
----------------------------------------------------------------------------------

                 Key: QPID-3905
                 URL: https://issues.apache.org/jira/browse/QPID-3905
             Project: Qpid
          Issue Type: Bug
          Components: Java Client
    Affects Versions: 0.14
            Reporter: Alex Rudyy


NullPointerException is thrown on rejecting messages whilst closing the connection.

The dispatcher is set to null at this point and accessing it causing the NullPointerException.

2012-03-21 06:04:29,946 ERROR [AMQProtocolHandler] Exception processing frame
java.lang.NullPointerException
	at org.apache.qpid.client.AMQSession$Dispatcher.rejectPending(AMQSession.java:3217)
	at org.apache.qpid.client.AMQSession.confirmConsumerCancelled(AMQSession.java:903)
	at org.apache.qpid.client.protocol.AMQProtocolSession.confirmConsumerCancelled(AMQProtocolSession.java:397)
	at org.apache.qpid.client.handler.BasicCancelOkMethodHandler.methodReceived(BasicCancelOkMethodHandler.java:53)
	at org.apache.qpid.client.handler.ClientMethodDispatcherImpl.dispatchBasicCancelOk(ClientMethodDispatcherImpl.java:126)
	at org.apache.qpid.framing.amqp_0_9.BasicCancelOkBodyImpl.execute(BasicCancelOkBodyImpl.java:110)
	at org.apache.qpid.client.state.AMQStateManager.methodReceived(AMQStateManager.java:114)
	at org.apache.qpid.client.protocol.AMQProtocolHandler.methodBodyReceived(AMQProtocolHandler.java:479)
	at org.apache.qpid.client.protocol.AMQProtocolSession.methodFrameReceived(AMQProtocolSession.java:455)
	at org.apache.qpid.framing.AMQMethodBodyImpl.handle(AMQMethodBodyImpl.java:97)
	at org.apache.qpid.client.protocol.AMQProtocolHandler.received(AMQProtocolHandler.java:436)
	at org.apache.qpid.client.protocol.AMQProtocolHandler.received(AMQProtocolHandler.java:121)
	at org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:152)
	at java.lang.Thread.run(Thread.java:662)


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Assigned] (QPID-3905) NullPointerException is thrown on rejecting messages whilst closing the connection

Posted by "Keith Wall (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith Wall reassigned QPID-3905:
--------------------------------

    Assignee: Alex Rudyy  (was: Keith Wall)
    
> NullPointerException is thrown on rejecting messages whilst closing the connection
> ----------------------------------------------------------------------------------
>
>                 Key: QPID-3905
>                 URL: https://issues.apache.org/jira/browse/QPID-3905
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: 0.14, 0.15, 0.16, 0.17
>            Reporter: Alex Rudyy
>            Assignee: Alex Rudyy
>             Fix For: 0.17
>
>
> NullPointerException is thrown on rejecting messages whilst closing the connection.
> The dispatcher is set to null at this point and accessing it causing the NullPointerException.
> 2012-03-21 06:04:29,946 ERROR [AMQProtocolHandler] Exception processing frame
> java.lang.NullPointerException
> 	at org.apache.qpid.client.AMQSession$Dispatcher.rejectPending(AMQSession.java:3217)
> 	at org.apache.qpid.client.AMQSession.confirmConsumerCancelled(AMQSession.java:903)
> 	at org.apache.qpid.client.protocol.AMQProtocolSession.confirmConsumerCancelled(AMQProtocolSession.java:397)
> 	at org.apache.qpid.client.handler.BasicCancelOkMethodHandler.methodReceived(BasicCancelOkMethodHandler.java:53)
> 	at org.apache.qpid.client.handler.ClientMethodDispatcherImpl.dispatchBasicCancelOk(ClientMethodDispatcherImpl.java:126)
> 	at org.apache.qpid.framing.amqp_0_9.BasicCancelOkBodyImpl.execute(BasicCancelOkBodyImpl.java:110)
> 	at org.apache.qpid.client.state.AMQStateManager.methodReceived(AMQStateManager.java:114)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.methodBodyReceived(AMQProtocolHandler.java:479)
> 	at org.apache.qpid.client.protocol.AMQProtocolSession.methodFrameReceived(AMQProtocolSession.java:455)
> 	at org.apache.qpid.framing.AMQMethodBodyImpl.handle(AMQMethodBodyImpl.java:97)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.received(AMQProtocolHandler.java:436)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.received(AMQProtocolHandler.java:121)
> 	at org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:152)
> 	at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Commented] (QPID-3905) NullPointerException is thrown on rejecting messages whilst closing the connection

Posted by "Keith Wall (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236465#comment-13236465 ] 

Keith Wall commented on QPID-3905:
----------------------------------

I wonder if my change for QPID-3807 has exposed this defect.

The method Dispatcher#rejectPending (oddly) refers to *itself* via the field AMQSession#_dispatcher rather than making method calls on itself.  Before QPID-3807, updates to the fields were made in a thread-unsafe manner so it is possible that the Dispatcher, reading stale copies of the fields, allowed this bug to go unnoticed.

I see no reason for #rejectPending to use _dispatcher, and think we should change it to call the method directly.

We should probably consider having this included in 0-16.


                
> NullPointerException is thrown on rejecting messages whilst closing the connection
> ----------------------------------------------------------------------------------
>
>                 Key: QPID-3905
>                 URL: https://issues.apache.org/jira/browse/QPID-3905
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: 0.14
>            Reporter: Alex Rudyy
>
> NullPointerException is thrown on rejecting messages whilst closing the connection.
> The dispatcher is set to null at this point and accessing it causing the NullPointerException.
> 2012-03-21 06:04:29,946 ERROR [AMQProtocolHandler] Exception processing frame
> java.lang.NullPointerException
> 	at org.apache.qpid.client.AMQSession$Dispatcher.rejectPending(AMQSession.java:3217)
> 	at org.apache.qpid.client.AMQSession.confirmConsumerCancelled(AMQSession.java:903)
> 	at org.apache.qpid.client.protocol.AMQProtocolSession.confirmConsumerCancelled(AMQProtocolSession.java:397)
> 	at org.apache.qpid.client.handler.BasicCancelOkMethodHandler.methodReceived(BasicCancelOkMethodHandler.java:53)
> 	at org.apache.qpid.client.handler.ClientMethodDispatcherImpl.dispatchBasicCancelOk(ClientMethodDispatcherImpl.java:126)
> 	at org.apache.qpid.framing.amqp_0_9.BasicCancelOkBodyImpl.execute(BasicCancelOkBodyImpl.java:110)
> 	at org.apache.qpid.client.state.AMQStateManager.methodReceived(AMQStateManager.java:114)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.methodBodyReceived(AMQProtocolHandler.java:479)
> 	at org.apache.qpid.client.protocol.AMQProtocolSession.methodFrameReceived(AMQProtocolSession.java:455)
> 	at org.apache.qpid.framing.AMQMethodBodyImpl.handle(AMQMethodBodyImpl.java:97)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.received(AMQProtocolHandler.java:436)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.received(AMQProtocolHandler.java:121)
> 	at org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:152)
> 	at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Updated] (QPID-3905) NullPointerException is thrown on rejecting messages whilst closing the connection

Posted by "Keith Wall (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith Wall updated QPID-3905:
-----------------------------

    Affects Version/s: 0.17
                       0.16
                       0.15
        Fix Version/s: 0.17
             Assignee: Keith Wall
    
> NullPointerException is thrown on rejecting messages whilst closing the connection
> ----------------------------------------------------------------------------------
>
>                 Key: QPID-3905
>                 URL: https://issues.apache.org/jira/browse/QPID-3905
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: 0.14, 0.15, 0.16, 0.17
>            Reporter: Alex Rudyy
>            Assignee: Keith Wall
>             Fix For: 0.17
>
>
> NullPointerException is thrown on rejecting messages whilst closing the connection.
> The dispatcher is set to null at this point and accessing it causing the NullPointerException.
> 2012-03-21 06:04:29,946 ERROR [AMQProtocolHandler] Exception processing frame
> java.lang.NullPointerException
> 	at org.apache.qpid.client.AMQSession$Dispatcher.rejectPending(AMQSession.java:3217)
> 	at org.apache.qpid.client.AMQSession.confirmConsumerCancelled(AMQSession.java:903)
> 	at org.apache.qpid.client.protocol.AMQProtocolSession.confirmConsumerCancelled(AMQProtocolSession.java:397)
> 	at org.apache.qpid.client.handler.BasicCancelOkMethodHandler.methodReceived(BasicCancelOkMethodHandler.java:53)
> 	at org.apache.qpid.client.handler.ClientMethodDispatcherImpl.dispatchBasicCancelOk(ClientMethodDispatcherImpl.java:126)
> 	at org.apache.qpid.framing.amqp_0_9.BasicCancelOkBodyImpl.execute(BasicCancelOkBodyImpl.java:110)
> 	at org.apache.qpid.client.state.AMQStateManager.methodReceived(AMQStateManager.java:114)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.methodBodyReceived(AMQProtocolHandler.java:479)
> 	at org.apache.qpid.client.protocol.AMQProtocolSession.methodFrameReceived(AMQProtocolSession.java:455)
> 	at org.apache.qpid.framing.AMQMethodBodyImpl.handle(AMQMethodBodyImpl.java:97)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.received(AMQProtocolHandler.java:436)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.received(AMQProtocolHandler.java:121)
> 	at org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:152)
> 	at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Assigned] (QPID-3905) NullPointerException is thrown on rejecting messages whilst closing the connection

Posted by "Robbie Gemmell (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell reassigned QPID-3905:
------------------------------------

    Assignee: Robbie Gemmell  (was: Alex Rudyy)
    
> NullPointerException is thrown on rejecting messages whilst closing the connection
> ----------------------------------------------------------------------------------
>
>                 Key: QPID-3905
>                 URL: https://issues.apache.org/jira/browse/QPID-3905
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: 0.14, 0.15, 0.16, 0.17
>            Reporter: Alex Rudyy
>            Assignee: Robbie Gemmell
>             Fix For: 0.17
>
>
> NullPointerException is thrown on rejecting messages whilst closing the connection.
> The dispatcher is set to null at this point and accessing it causing the NullPointerException.
> 2012-03-21 06:04:29,946 ERROR [AMQProtocolHandler] Exception processing frame
> java.lang.NullPointerException
> 	at org.apache.qpid.client.AMQSession$Dispatcher.rejectPending(AMQSession.java:3217)
> 	at org.apache.qpid.client.AMQSession.confirmConsumerCancelled(AMQSession.java:903)
> 	at org.apache.qpid.client.protocol.AMQProtocolSession.confirmConsumerCancelled(AMQProtocolSession.java:397)
> 	at org.apache.qpid.client.handler.BasicCancelOkMethodHandler.methodReceived(BasicCancelOkMethodHandler.java:53)
> 	at org.apache.qpid.client.handler.ClientMethodDispatcherImpl.dispatchBasicCancelOk(ClientMethodDispatcherImpl.java:126)
> 	at org.apache.qpid.framing.amqp_0_9.BasicCancelOkBodyImpl.execute(BasicCancelOkBodyImpl.java:110)
> 	at org.apache.qpid.client.state.AMQStateManager.methodReceived(AMQStateManager.java:114)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.methodBodyReceived(AMQProtocolHandler.java:479)
> 	at org.apache.qpid.client.protocol.AMQProtocolSession.methodFrameReceived(AMQProtocolSession.java:455)
> 	at org.apache.qpid.framing.AMQMethodBodyImpl.handle(AMQMethodBodyImpl.java:97)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.received(AMQProtocolHandler.java:436)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.received(AMQProtocolHandler.java:121)
> 	at org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:152)
> 	at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Updated] (QPID-3905) NullPointerException is thrown on rejecting messages whilst closing the connection

Posted by "Keith Wall (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith Wall updated QPID-3905:
-----------------------------

    Status: Ready To Review  (was: In Progress)
    
> NullPointerException is thrown on rejecting messages whilst closing the connection
> ----------------------------------------------------------------------------------
>
>                 Key: QPID-3905
>                 URL: https://issues.apache.org/jira/browse/QPID-3905
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: 0.14, 0.15, 0.16, 0.17
>            Reporter: Alex Rudyy
>            Assignee: Keith Wall
>             Fix For: 0.17
>
>
> NullPointerException is thrown on rejecting messages whilst closing the connection.
> The dispatcher is set to null at this point and accessing it causing the NullPointerException.
> 2012-03-21 06:04:29,946 ERROR [AMQProtocolHandler] Exception processing frame
> java.lang.NullPointerException
> 	at org.apache.qpid.client.AMQSession$Dispatcher.rejectPending(AMQSession.java:3217)
> 	at org.apache.qpid.client.AMQSession.confirmConsumerCancelled(AMQSession.java:903)
> 	at org.apache.qpid.client.protocol.AMQProtocolSession.confirmConsumerCancelled(AMQProtocolSession.java:397)
> 	at org.apache.qpid.client.handler.BasicCancelOkMethodHandler.methodReceived(BasicCancelOkMethodHandler.java:53)
> 	at org.apache.qpid.client.handler.ClientMethodDispatcherImpl.dispatchBasicCancelOk(ClientMethodDispatcherImpl.java:126)
> 	at org.apache.qpid.framing.amqp_0_9.BasicCancelOkBodyImpl.execute(BasicCancelOkBodyImpl.java:110)
> 	at org.apache.qpid.client.state.AMQStateManager.methodReceived(AMQStateManager.java:114)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.methodBodyReceived(AMQProtocolHandler.java:479)
> 	at org.apache.qpid.client.protocol.AMQProtocolSession.methodFrameReceived(AMQProtocolSession.java:455)
> 	at org.apache.qpid.framing.AMQMethodBodyImpl.handle(AMQMethodBodyImpl.java:97)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.received(AMQProtocolHandler.java:436)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.received(AMQProtocolHandler.java:121)
> 	at org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:152)
> 	at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Updated] (QPID-3905) NullPointerException is thrown on rejecting messages whilst closing the connection

Posted by "Robbie Gemmell (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell updated QPID-3905:
---------------------------------

    Affects Version/s:     (was: 0.17)
                           (was: 0.16)
        Fix Version/s:     (was: 0.17)
                       0.16

Changes merged to the 0.16 branch.
                
> NullPointerException is thrown on rejecting messages whilst closing the connection
> ----------------------------------------------------------------------------------
>
>                 Key: QPID-3905
>                 URL: https://issues.apache.org/jira/browse/QPID-3905
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: 0.14, 0.15
>            Reporter: Alex Rudyy
>            Assignee: Robbie Gemmell
>             Fix For: 0.16
>
>
> NullPointerException is thrown on rejecting messages whilst closing the connection.
> The dispatcher is set to null at this point and accessing it causing the NullPointerException.
> 2012-03-21 06:04:29,946 ERROR [AMQProtocolHandler] Exception processing frame
> java.lang.NullPointerException
> 	at org.apache.qpid.client.AMQSession$Dispatcher.rejectPending(AMQSession.java:3217)
> 	at org.apache.qpid.client.AMQSession.confirmConsumerCancelled(AMQSession.java:903)
> 	at org.apache.qpid.client.protocol.AMQProtocolSession.confirmConsumerCancelled(AMQProtocolSession.java:397)
> 	at org.apache.qpid.client.handler.BasicCancelOkMethodHandler.methodReceived(BasicCancelOkMethodHandler.java:53)
> 	at org.apache.qpid.client.handler.ClientMethodDispatcherImpl.dispatchBasicCancelOk(ClientMethodDispatcherImpl.java:126)
> 	at org.apache.qpid.framing.amqp_0_9.BasicCancelOkBodyImpl.execute(BasicCancelOkBodyImpl.java:110)
> 	at org.apache.qpid.client.state.AMQStateManager.methodReceived(AMQStateManager.java:114)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.methodBodyReceived(AMQProtocolHandler.java:479)
> 	at org.apache.qpid.client.protocol.AMQProtocolSession.methodFrameReceived(AMQProtocolSession.java:455)
> 	at org.apache.qpid.framing.AMQMethodBodyImpl.handle(AMQMethodBodyImpl.java:97)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.received(AMQProtocolHandler.java:436)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.received(AMQProtocolHandler.java:121)
> 	at org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:152)
> 	at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Commented] (QPID-3905) NullPointerException is thrown on rejecting messages whilst closing the connection

Posted by "Justin Ross (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250986#comment-13250986 ] 

Justin Ross commented on QPID-3905:
-----------------------------------

Reviewed by Robbie.  Approved for 0.16.
                
> NullPointerException is thrown on rejecting messages whilst closing the connection
> ----------------------------------------------------------------------------------
>
>                 Key: QPID-3905
>                 URL: https://issues.apache.org/jira/browse/QPID-3905
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: 0.14, 0.15, 0.16, 0.17
>            Reporter: Alex Rudyy
>            Assignee: Robbie Gemmell
>             Fix For: 0.17
>
>
> NullPointerException is thrown on rejecting messages whilst closing the connection.
> The dispatcher is set to null at this point and accessing it causing the NullPointerException.
> 2012-03-21 06:04:29,946 ERROR [AMQProtocolHandler] Exception processing frame
> java.lang.NullPointerException
> 	at org.apache.qpid.client.AMQSession$Dispatcher.rejectPending(AMQSession.java:3217)
> 	at org.apache.qpid.client.AMQSession.confirmConsumerCancelled(AMQSession.java:903)
> 	at org.apache.qpid.client.protocol.AMQProtocolSession.confirmConsumerCancelled(AMQProtocolSession.java:397)
> 	at org.apache.qpid.client.handler.BasicCancelOkMethodHandler.methodReceived(BasicCancelOkMethodHandler.java:53)
> 	at org.apache.qpid.client.handler.ClientMethodDispatcherImpl.dispatchBasicCancelOk(ClientMethodDispatcherImpl.java:126)
> 	at org.apache.qpid.framing.amqp_0_9.BasicCancelOkBodyImpl.execute(BasicCancelOkBodyImpl.java:110)
> 	at org.apache.qpid.client.state.AMQStateManager.methodReceived(AMQStateManager.java:114)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.methodBodyReceived(AMQProtocolHandler.java:479)
> 	at org.apache.qpid.client.protocol.AMQProtocolSession.methodFrameReceived(AMQProtocolSession.java:455)
> 	at org.apache.qpid.framing.AMQMethodBodyImpl.handle(AMQMethodBodyImpl.java:97)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.received(AMQProtocolHandler.java:436)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.received(AMQProtocolHandler.java:121)
> 	at org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:152)
> 	at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Commented] (QPID-3905) NullPointerException is thrown on rejecting messages whilst closing the connection

Posted by "Keith Wall (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237737#comment-13237737 ] 

Keith Wall commented on QPID-3905:
----------------------------------

Patch applied.  Alex, could you review please?
                
> NullPointerException is thrown on rejecting messages whilst closing the connection
> ----------------------------------------------------------------------------------
>
>                 Key: QPID-3905
>                 URL: https://issues.apache.org/jira/browse/QPID-3905
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: 0.14, 0.15, 0.16, 0.17
>            Reporter: Alex Rudyy
>            Assignee: Keith Wall
>             Fix For: 0.17
>
>
> NullPointerException is thrown on rejecting messages whilst closing the connection.
> The dispatcher is set to null at this point and accessing it causing the NullPointerException.
> 2012-03-21 06:04:29,946 ERROR [AMQProtocolHandler] Exception processing frame
> java.lang.NullPointerException
> 	at org.apache.qpid.client.AMQSession$Dispatcher.rejectPending(AMQSession.java:3217)
> 	at org.apache.qpid.client.AMQSession.confirmConsumerCancelled(AMQSession.java:903)
> 	at org.apache.qpid.client.protocol.AMQProtocolSession.confirmConsumerCancelled(AMQProtocolSession.java:397)
> 	at org.apache.qpid.client.handler.BasicCancelOkMethodHandler.methodReceived(BasicCancelOkMethodHandler.java:53)
> 	at org.apache.qpid.client.handler.ClientMethodDispatcherImpl.dispatchBasicCancelOk(ClientMethodDispatcherImpl.java:126)
> 	at org.apache.qpid.framing.amqp_0_9.BasicCancelOkBodyImpl.execute(BasicCancelOkBodyImpl.java:110)
> 	at org.apache.qpid.client.state.AMQStateManager.methodReceived(AMQStateManager.java:114)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.methodBodyReceived(AMQProtocolHandler.java:479)
> 	at org.apache.qpid.client.protocol.AMQProtocolSession.methodFrameReceived(AMQProtocolSession.java:455)
> 	at org.apache.qpid.framing.AMQMethodBodyImpl.handle(AMQMethodBodyImpl.java:97)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.received(AMQProtocolHandler.java:436)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.received(AMQProtocolHandler.java:121)
> 	at org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:152)
> 	at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Resolved] (QPID-3905) NullPointerException is thrown on rejecting messages whilst closing the connection

Posted by "Robbie Gemmell (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell resolved QPID-3905.
----------------------------------

    Resolution: Fixed

Changes look good to me. This ought to be requested for 0.16 since even if it could have potentially happened previously we have effectively made it far far more likely to show up since 0.14.
                
> NullPointerException is thrown on rejecting messages whilst closing the connection
> ----------------------------------------------------------------------------------
>
>                 Key: QPID-3905
>                 URL: https://issues.apache.org/jira/browse/QPID-3905
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: 0.14, 0.15, 0.16, 0.17
>            Reporter: Alex Rudyy
>            Assignee: Robbie Gemmell
>             Fix For: 0.17
>
>
> NullPointerException is thrown on rejecting messages whilst closing the connection.
> The dispatcher is set to null at this point and accessing it causing the NullPointerException.
> 2012-03-21 06:04:29,946 ERROR [AMQProtocolHandler] Exception processing frame
> java.lang.NullPointerException
> 	at org.apache.qpid.client.AMQSession$Dispatcher.rejectPending(AMQSession.java:3217)
> 	at org.apache.qpid.client.AMQSession.confirmConsumerCancelled(AMQSession.java:903)
> 	at org.apache.qpid.client.protocol.AMQProtocolSession.confirmConsumerCancelled(AMQProtocolSession.java:397)
> 	at org.apache.qpid.client.handler.BasicCancelOkMethodHandler.methodReceived(BasicCancelOkMethodHandler.java:53)
> 	at org.apache.qpid.client.handler.ClientMethodDispatcherImpl.dispatchBasicCancelOk(ClientMethodDispatcherImpl.java:126)
> 	at org.apache.qpid.framing.amqp_0_9.BasicCancelOkBodyImpl.execute(BasicCancelOkBodyImpl.java:110)
> 	at org.apache.qpid.client.state.AMQStateManager.methodReceived(AMQStateManager.java:114)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.methodBodyReceived(AMQProtocolHandler.java:479)
> 	at org.apache.qpid.client.protocol.AMQProtocolSession.methodFrameReceived(AMQProtocolSession.java:455)
> 	at org.apache.qpid.framing.AMQMethodBodyImpl.handle(AMQMethodBodyImpl.java:97)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.received(AMQProtocolHandler.java:436)
> 	at org.apache.qpid.client.protocol.AMQProtocolHandler.received(AMQProtocolHandler.java:121)
> 	at org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:152)
> 	at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org