You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Abdullah Shaikh (JIRA)" <ji...@apache.org> on 2009/11/09 17:33:33 UTC
[jira] Created: (OFBIZ-3180) SagePay payment gateway integrated
SagePay payment gateway integrated
----------------------------------
Key: OFBIZ-3180
URL: https://issues.apache.org/jira/browse/OFBIZ-3180
Project: OFBiz
Issue Type: New Feature
Components: accounting
Reporter: Abdullah Shaikh
SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3180) SagePay payment gateway integrated
Posted by "Abdullah Shaikh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Abdullah Shaikh updated OFBIZ-3180:
-----------------------------------
Attachment: jcip-annotations-1.0.jar
> SagePay payment gateway integrated
> ----------------------------------
>
> Key: OFBIZ-3180
> URL: https://issues.apache.org/jira/browse/OFBIZ-3180
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting
> Reporter: Abdullah Shaikh
> Attachments: httpclient-4.0.jar, httpcore-4.0.1.jar, jcip-annotations-1.0.jar, OFBIZ-3180_SagePay payment gateway.patch
>
>
> SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3180) SagePay payment gateway integrated
Posted by "Abdullah Shaikh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Abdullah Shaikh updated OFBIZ-3180:
-----------------------------------
Attachment: httpcore-4.0.1.jar
httpclient-4.0.jar
OFBIZ-3180_SagePay payment gateway.patch
> SagePay payment gateway integrated
> ----------------------------------
>
> Key: OFBIZ-3180
> URL: https://issues.apache.org/jira/browse/OFBIZ-3180
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting
> Reporter: Abdullah Shaikh
> Attachments: httpclient-4.0.jar, httpcore-4.0.1.jar, OFBIZ-3180_SagePay payment gateway.patch
>
>
> SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3180) SagePay payment gateway integrated
Posted by "Abdullah Shaikh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775303#action_12775303 ]
Abdullah Shaikh commented on OFBIZ-3180:
----------------------------------------
Thanks Jacques for the review, apart from the space between if and (, I also have some more things, like providing a drop down for transaction types during payment gateway configuration, in mind, and also will look for more improvements, will submit the patch for them once this code gets in.
> SagePay payment gateway integrated
> ----------------------------------
>
> Key: OFBIZ-3180
> URL: https://issues.apache.org/jira/browse/OFBIZ-3180
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting
> Reporter: Abdullah Shaikh
> Attachments: httpclient-4.0.jar, httpcore-4.0.1.jar, jcip-annotations-1.0.jar, OFBIZ-3180_SagePay payment gateway.patch
>
>
> SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3180) SagePay payment gateway integrated
Posted by "Abdullah Shaikh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779889#action_12779889 ]
Abdullah Shaikh commented on OFBIZ-3180:
----------------------------------------
Hi Jacques,
The http*.jar are Release 4.0. Yes I just saw there are 4.0 betas there, shouldn't we remove the betas with the release version ? Should I raise a separate jira for this ?
Thanks
> SagePay payment gateway integrated
> ----------------------------------
>
> Key: OFBIZ-3180
> URL: https://issues.apache.org/jira/browse/OFBIZ-3180
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting
> Reporter: Abdullah Shaikh
> Assignee: Jacques Le Roux
> Attachments: httpclient-4.0.jar, httpcore-4.0.1.jar, jcip-annotations-1.0.jar, OFBIZ-3180_SagePay payment gateway.patch
>
>
> SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3180) SagePay payment gateway integrated
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775150#action_12775150 ]
Jacques Le Roux commented on OFBIZ-3180:
----------------------------------------
I'd just put a white space between if and (
> SagePay payment gateway integrated
> ----------------------------------
>
> Key: OFBIZ-3180
> URL: https://issues.apache.org/jira/browse/OFBIZ-3180
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting
> Reporter: Abdullah Shaikh
> Attachments: httpclient-4.0.jar, httpcore-4.0.1.jar, jcip-annotations-1.0.jar, OFBIZ-3180_SagePay payment gateway.patch
>
>
> SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3180) SagePay payment gateway integrated
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779910#action_12779910 ]
Jacques Le Roux commented on OFBIZ-3180:
----------------------------------------
Cool thanks
> SagePay payment gateway integrated
> ----------------------------------
>
> Key: OFBIZ-3180
> URL: https://issues.apache.org/jira/browse/OFBIZ-3180
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting
> Reporter: Abdullah Shaikh
> Assignee: Jacques Le Roux
> Attachments: httpclient-4.0.jar, httpcore-4.0.1.jar, jcip-annotations-1.0.jar, OFBIZ-3180_SagePay payment gateway.patch
>
>
> SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3180) SagePay payment gateway integrated
Posted by "Abdullah Shaikh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780533#action_12780533 ]
Abdullah Shaikh commented on OFBIZ-3180:
----------------------------------------
oops sorry for the confusion .. yes it's working fine .. thanks
> SagePay payment gateway integrated
> ----------------------------------
>
> Key: OFBIZ-3180
> URL: https://issues.apache.org/jira/browse/OFBIZ-3180
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting
> Reporter: Abdullah Shaikh
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: httpclient-4.0.jar, httpcore-4.0.1.jar, jcip-annotations-1.0.jar, OFBIZ-3180_SagePay payment gateway.patch
>
>
> SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3180) SagePay payment gateway integrated
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779900#action_12779900 ]
Jacques Le Roux commented on OFBIZ-3180:
----------------------------------------
A detail I forgot, please when you use [Eclipse internal command don't use finish and rather select project to avoid the 2 1st lines in the patch|http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices#OFBizContributorsBestPractices-HowtoSendinYourContributions(orhowtocreateandapplypatches)]
> SagePay payment gateway integrated
> ----------------------------------
>
> Key: OFBIZ-3180
> URL: https://issues.apache.org/jira/browse/OFBIZ-3180
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting
> Reporter: Abdullah Shaikh
> Assignee: Jacques Le Roux
> Attachments: httpclient-4.0.jar, httpcore-4.0.1.jar, jcip-annotations-1.0.jar, OFBIZ-3180_SagePay payment gateway.patch
>
>
> SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3180) SagePay payment gateway integrated
Posted by "Abdullah Shaikh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779908#action_12779908 ]
Abdullah Shaikh commented on OFBIZ-3180:
----------------------------------------
I will keep that in mind, but I don't know how these lines came, as the other patches that I submitted weren't having them.
Regarding the jar thing, before I could get your message I already raised that issue here https://issues.apache.org/jira/browse/OFBIZ-3224, we already had a discussion on this on ML long back, and you suggested to open a jira, so when again the same thing got back, I just opened the jira.
> SagePay payment gateway integrated
> ----------------------------------
>
> Key: OFBIZ-3180
> URL: https://issues.apache.org/jira/browse/OFBIZ-3180
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting
> Reporter: Abdullah Shaikh
> Assignee: Jacques Le Roux
> Attachments: httpclient-4.0.jar, httpcore-4.0.1.jar, jcip-annotations-1.0.jar, OFBIZ-3180_SagePay payment gateway.patch
>
>
> SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3180) SagePay payment gateway integrated
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780504#action_12780504 ]
Jacques Le Roux commented on OFBIZ-3180:
----------------------------------------
Hi Abdullah,
At r882337, I had to change mode to sagePayMode because MODE is a SQL reserved word. Could you please check it still works well ?
Thanks
> SagePay payment gateway integrated
> ----------------------------------
>
> Key: OFBIZ-3180
> URL: https://issues.apache.org/jira/browse/OFBIZ-3180
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting
> Reporter: Abdullah Shaikh
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: httpclient-4.0.jar, httpcore-4.0.1.jar, jcip-annotations-1.0.jar, OFBIZ-3180_SagePay payment gateway.patch
>
>
> SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3180) SagePay payment gateway integrated
Posted by "Abdullah Shaikh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779939#action_12779939 ]
Abdullah Shaikh commented on OFBIZ-3180:
----------------------------------------
Thanks Jacques, thank you very much :)
> SagePay payment gateway integrated
> ----------------------------------
>
> Key: OFBIZ-3180
> URL: https://issues.apache.org/jira/browse/OFBIZ-3180
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting
> Reporter: Abdullah Shaikh
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: httpclient-4.0.jar, httpcore-4.0.1.jar, jcip-annotations-1.0.jar, OFBIZ-3180_SagePay payment gateway.patch
>
>
> SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3180) SagePay payment gateway integrated
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reassigned OFBIZ-3180:
--------------------------------------
Assignee: Jacques Le Roux
> SagePay payment gateway integrated
> ----------------------------------
>
> Key: OFBIZ-3180
> URL: https://issues.apache.org/jira/browse/OFBIZ-3180
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting
> Reporter: Abdullah Shaikh
> Assignee: Jacques Le Roux
> Attachments: httpclient-4.0.jar, httpcore-4.0.1.jar, jcip-annotations-1.0.jar, OFBIZ-3180_SagePay payment gateway.patch
>
>
> SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3180) SagePay payment gateway integrated
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775148#action_12775148 ]
Jacques Le Roux commented on OFBIZ-3180:
----------------------------------------
Thanks Abdullah,
Very cursory review : looks good
> SagePay payment gateway integrated
> ----------------------------------
>
> Key: OFBIZ-3180
> URL: https://issues.apache.org/jira/browse/OFBIZ-3180
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting
> Reporter: Abdullah Shaikh
> Attachments: httpclient-4.0.jar, httpcore-4.0.1.jar, jcip-annotations-1.0.jar, OFBIZ-3180_SagePay payment gateway.patch
>
>
> SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3180) SagePay payment gateway integrated
Posted by "Abdullah Shaikh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780508#action_12780508 ]
Abdullah Shaikh commented on OFBIZ-3180:
----------------------------------------
Fine. I will provide a patch for this.
> SagePay payment gateway integrated
> ----------------------------------
>
> Key: OFBIZ-3180
> URL: https://issues.apache.org/jira/browse/OFBIZ-3180
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting
> Reporter: Abdullah Shaikh
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: httpclient-4.0.jar, httpcore-4.0.1.jar, jcip-annotations-1.0.jar, OFBIZ-3180_SagePay payment gateway.patch
>
>
> SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3180) SagePay payment gateway integrated
Posted by "Hans Bakker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791116#action_12791116 ]
Hans Bakker commented on OFBIZ-3180:
------------------------------------
more info at: http://blogsbyabdullah.blogspot.com/2009/11/sagepay-payment-gateway-configuration.html
> SagePay payment gateway integrated
> ----------------------------------
>
> Key: OFBIZ-3180
> URL: https://issues.apache.org/jira/browse/OFBIZ-3180
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting
> Reporter: Abdullah Shaikh
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: httpclient-4.0.jar, httpcore-4.0.1.jar, jcip-annotations-1.0.jar, OFBIZ-3180_SagePay payment gateway.patch
>
>
> SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3180) SagePay payment gateway integrated
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780522#action_12780522 ]
Jacques Le Roux commented on OFBIZ-3180:
----------------------------------------
A patch ? What for ?
> SagePay payment gateway integrated
> ----------------------------------
>
> Key: OFBIZ-3180
> URL: https://issues.apache.org/jira/browse/OFBIZ-3180
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting
> Reporter: Abdullah Shaikh
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: httpclient-4.0.jar, httpcore-4.0.1.jar, jcip-annotations-1.0.jar, OFBIZ-3180_SagePay payment gateway.patch
>
>
> SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3180) SagePay payment gateway integrated
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779857#action_12779857 ]
Jacques Le Roux commented on OFBIZ-3180:
----------------------------------------
Hi Abdullah,
I had a new look. Do you know which are the http*.jar versions ? We have already 4.0-betas in OFBIz.. I suppose it's 4.0 stable for client as it has been announced the 2009-08-13 but for core ?
Thanks
> SagePay payment gateway integrated
> ----------------------------------
>
> Key: OFBIZ-3180
> URL: https://issues.apache.org/jira/browse/OFBIZ-3180
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting
> Reporter: Abdullah Shaikh
> Assignee: Jacques Le Roux
> Attachments: httpclient-4.0.jar, httpcore-4.0.1.jar, jcip-annotations-1.0.jar, OFBIZ-3180_SagePay payment gateway.patch
>
>
> SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3180) SagePay payment gateway integrated
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779904#action_12779904 ]
Jacques Le Roux commented on OFBIZ-3180:
----------------------------------------
Of course don't update this one ;)
> SagePay payment gateway integrated
> ----------------------------------
>
> Key: OFBIZ-3180
> URL: https://issues.apache.org/jira/browse/OFBIZ-3180
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting
> Reporter: Abdullah Shaikh
> Assignee: Jacques Le Roux
> Attachments: httpclient-4.0.jar, httpcore-4.0.1.jar, jcip-annotations-1.0.jar, OFBIZ-3180_SagePay payment gateway.patch
>
>
> SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3180) SagePay payment gateway integrated
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779898#action_12779898 ]
Jacques Le Roux commented on OFBIZ-3180:
----------------------------------------
Thanks Abdullah,
Don't worry I will handle that.
We have also to fill some places with these informations.
If interested have a look at the commit I will do "soon"
We also update this document http://docs.ofbiz.org/display/OFBADMIN/Libraries+Included+in+OFBiz
> SagePay payment gateway integrated
> ----------------------------------
>
> Key: OFBIZ-3180
> URL: https://issues.apache.org/jira/browse/OFBIZ-3180
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting
> Reporter: Abdullah Shaikh
> Assignee: Jacques Le Roux
> Attachments: httpclient-4.0.jar, httpcore-4.0.1.jar, jcip-annotations-1.0.jar, OFBIZ-3180_SagePay payment gateway.patch
>
>
> SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3180) SagePay payment gateway integrated
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-3180.
----------------------------------
Resolution: Fixed
Fix Version/s: SVN trunk
Thanks Abdullah,
Your (slightly modified) patch is in trunk at r882103
Some small details I changed (else your code was very well done)
* We son't need to put such comment in labels files (else we will finish with plenty) : <!-- labels for SagePay payment gateway -->
* you forgot the white spaces between if and ( ;)
* when possible, prefer enhanced for loops on iterators
* in general please follow our [Coding+Conventions|http://docs.ofbiz.org/display/OFBADMIN/Coding+Conventions]. Most of the time I use Ctrl+Shft+F in Eclipse for that (only on code snippets and with a larger line than default - 150 instead of 80- else it breaks all) but I kept yours in the snippet beginning by
{code}
if (vendorTxCode != null) { parameters.put("VendorTxCode", vendorTxCode); }
{code}
because it was much more easier to read
* I remove this code snippet (vars never read)
{code}
String avsCv2 = (String) paymentResult.get("avsCv2");
String addressResult = (String) paymentResult.get("addressResult");
String postCodeResult = (String) paymentResult.get("postCodeResult");
String cv2Result = (String) paymentResult.get("cv2Result");
{code}
* as you I always use authorised (because it's how it's written ion French) but it's actually authorized (thanks to Eclipse automatic language check)
> SagePay payment gateway integrated
> ----------------------------------
>
> Key: OFBIZ-3180
> URL: https://issues.apache.org/jira/browse/OFBIZ-3180
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting
> Reporter: Abdullah Shaikh
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: httpclient-4.0.jar, httpcore-4.0.1.jar, jcip-annotations-1.0.jar, OFBIZ-3180_SagePay payment gateway.patch
>
>
> SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.