[GitHub] [beam] TheNeuralBit commented on a diff in pull request #21835: Update references to jira to GH for the Runners

[GitBox <gi...@apache.org>]

TheNeuralBit commented on code in PR #21835:
URL: https://github.com/apache/beam/pull/21835#discussion_r897401219


##########
runners/spark/src/test/java/org/apache/beam/runners/spark/translation/streaming/ResumeFromCheckpointStreamingTest.java:
##########
@@ -351,8 +351,8 @@ public void process(ProcessContext c) {
   }
 
   /**
-   * A custom PAssert that avoids using {@link org.apache.beam.sdk.transforms.Flatten} until
-   * BEAM-1444 is resolved.
+   * A custom PAssert that avoids using {@link org.apache.beam.sdk.transforms.Flatten} until Issue
+   * 18144 is resolved.

Review Comment:
   Should this be a link?



##########
runners/core-java/src/test/java/org/apache/beam/runners/core/SimpleDoFnRunnerTest.java:
##########
@@ -68,7 +68,8 @@
 @RunWith(JUnit4.class)
 @SuppressWarnings({
   "rawtypes", // TODO(https://github.com/apache/beam/issues/20447)
-  "unused" // TODO(BEAM-13271): Remove when new version of errorprone is released (2.11.0)
+  "unused" // TODO(https://github.com/apache/beam/issues/21230): Remove when new version of
+  // errorprone is released (2.11.0)

Review Comment:
   Same here, I wonder if there's an easy way to clean these up (not a big deal if not).



##########
runners/flink/job-server/flink_job_server.gradle:
##########
@@ -193,17 +193,17 @@ def portableValidatesRunnerTask(String name, boolean streaming, boolean checkpoi
         excludeCategories 'org.apache.beam.sdk.testing.UsesPerKeyOrderInBundle'
     },
     testFilter: {
-      // TODO(BEAM-10016)
+      // TODO(https://github.com/apache/beam/issues/20269)
       excludeTestsMatching 'org.apache.beam.sdk.transforms.FlattenTest.testFlattenWithDifferentInputAndOutputCoders2'
-      // TODO(BEAM-12039)
+      // TODO(https://github.com/apache/beam/issues/20843)
       excludeTestsMatching 'org.apache.beam.sdk.testing.TestStreamTest.testDiscardingMode'
-      // TODO(BEAM-12038)
+      // TODO(https://github.com/apache/beam/issues/20844)
       excludeTestsMatching 'org.apache.beam.sdk.testing.TestStreamTest.testLateDataAccumulating'
       // TODO(BEAM-12710)
       excludeTestsMatching 'org.apache.beam.sdk.testing.TestStreamTest.testFirstElementLate'
       // TODO(BEAM-13498)
       excludeTestsMatching 'org.apache.beam.sdk.transforms.ParDoTest$TimestampTests.testProcessElementSkew'

Review Comment:
   Once this is done we should do another pass for references to closed jiras. Either the jira wasn't actually fixed and we should re-open the task, or the comment is out-dated and should be removed. In this case it looks like we may even be skipping a test that we shouldn't be.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org