You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Simon Comley (JIRA)" <ji...@apache.org> on 2007/09/05 16:29:32 UTC

[jira] Created: (WICKET-932) BaseWicketTester support for submitlink

BaseWicketTester support for submitlink
---------------------------------------

                 Key: WICKET-932
                 URL: https://issues.apache.org/jira/browse/WICKET-932
             Project: Wicket
          Issue Type: Bug
          Components: wicket-extensions
    Affects Versions: 1.3.0-beta2
         Environment: XP, Tomcat
            Reporter: Simon Comley
            Priority: Minor
             Fix For: 1.3.0-beta4


When the SubmitLink is used instead of the submit for forms, BaseWicketTester does not run through the onSubmit() code of the link.

I have stepped through the debug of the test that's actually not getting called. All my validators on the text field are getting called as expected and in fact the form works as expected when deployed so I'm thinking that it might be a WicketTester issue or the more likely scenario that I'm doing something wrong?

Things I've tried:
- debugging as mentioned, but this just shows me it's not getting called
- trying to call the link directly but I just get the below exception which I'm not really surpised about.... 


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (WICKET-932) BaseWicketTester support for SubmitLink

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525145 ] 

jbq edited comment on WICKET-932 at 9/5/07 9:26 AM:
---------------------------------------------------------------------

For now the only option is to do:

{noformat}
		// Pretend we clicked on "link"
		tester.getParametersForNextRequest().put("link", "");
		tester.submitForm("form");
{noformat}

Hopefully we can make it work using formTester.submit("link"); and tester.clickLink("form:link"); see org.apache.wicket.markup.html.form.submitlink.TestHomePage

      was (Author: jbq):
    For now the only option is to do:

{noformat}
		// Pretend we clicked on "link"
		tester.getParametersForNextRequest().put("link", "");
		tester.getParametersForNextRequest().put("link.x", "");
		tester.submitForm("form");
{noformat}

Hopefully we can make it work using formTester.submit("link"); and tester.clickLink("form:link"); see org.apache.wicket.markup.html.form.submitlink.TestHomePage
  
> BaseWicketTester support for SubmitLink
> ---------------------------------------
>
>                 Key: WICKET-932
>                 URL: https://issues.apache.org/jira/browse/WICKET-932
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.3.0-beta2
>         Environment: XP, Tomcat
>            Reporter: Simon Comley
>            Assignee: Jean-Baptiste Quenot
>            Priority: Minor
>             Fix For: 1.3.0-beta4
>
>         Attachments: JIRA932.zip
>
>
> When the SubmitLink is used instead of the submit for forms, BaseWicketTester does not run through the onSubmit() code of the link.
> I have stepped through the debug of the test that's actually not getting called. All my validators on the text field are getting called as expected and in fact the form works as expected when deployed so I'm thinking that it might be a WicketTester issue or the more likely scenario that I'm doing something wrong?
> Things I've tried:
> - debugging as mentioned, but this just shows me it's not getting called
> - trying to call the link directly but I just get the below exception which I'm not really surpised about.... 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-932) BaseWicketTester support for SubmitLink

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-932:
--------------------------------------

    Fix Version/s:     (was: 1.3.2)
                   1.3.3

> BaseWicketTester support for SubmitLink
> ---------------------------------------
>
>                 Key: WICKET-932
>                 URL: https://issues.apache.org/jira/browse/WICKET-932
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.3.0-beta2
>         Environment: XP, Tomcat
>            Reporter: Simon Comley
>            Priority: Minor
>             Fix For: 1.3.3
>
>         Attachments: JIRA932.zip
>
>
> When the SubmitLink is used instead of the submit for forms, BaseWicketTester does not run through the onSubmit() code of the link.
> I have stepped through the debug of the test that's actually not getting called. All my validators on the text field are getting called as expected and in fact the form works as expected when deployed so I'm thinking that it might be a WicketTester issue or the more likely scenario that I'm doing something wrong?
> Things I've tried:
> - debugging as mentioned, but this just shows me it's not getting called
> - trying to call the link directly but I just get the below exception which I'm not really surpised about.... 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-932) BaseWicketTester support for SubmitLink

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-932:
--------------------------------------

    Fix Version/s:     (was: 1.3.0-rc3)
                   1.3.1

> BaseWicketTester support for SubmitLink
> ---------------------------------------
>
>                 Key: WICKET-932
>                 URL: https://issues.apache.org/jira/browse/WICKET-932
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.3.0-beta2
>         Environment: XP, Tomcat
>            Reporter: Simon Comley
>            Assignee: Jean-Baptiste Quenot
>            Priority: Minor
>             Fix For: 1.3.1
>
>         Attachments: JIRA932.zip
>
>
> When the SubmitLink is used instead of the submit for forms, BaseWicketTester does not run through the onSubmit() code of the link.
> I have stepped through the debug of the test that's actually not getting called. All my validators on the text field are getting called as expected and in fact the form works as expected when deployed so I'm thinking that it might be a WicketTester issue or the more likely scenario that I'm doing something wrong?
> Things I've tried:
> - debugging as mentioned, but this just shows me it's not getting called
> - trying to call the link directly but I just get the below exception which I'm not really surpised about.... 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-932) BaseWicketTester support for SubmitLink

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525145 ] 

Jean-Baptiste Quenot commented on WICKET-932:
---------------------------------------------

For now the only option is to do:

{noformat}
		// Pretend we clicked on "link"
		tester.getParametersForNextRequest().put("link", "");
		tester.getParametersForNextRequest().put("link.x", "");
		tester.submitForm("form");
{noformat}

Hopefully we can make it work using formTester.submit("link"); and tester.clickLink("form:link"); see org.apache.wicket.markup.html.form.submitlink.TestHomePage

> BaseWicketTester support for SubmitLink
> ---------------------------------------
>
>                 Key: WICKET-932
>                 URL: https://issues.apache.org/jira/browse/WICKET-932
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.3.0-beta2
>         Environment: XP, Tomcat
>            Reporter: Simon Comley
>            Assignee: Jean-Baptiste Quenot
>            Priority: Minor
>             Fix For: 1.3.0-beta4
>
>         Attachments: JIRA932.zip
>
>
> When the SubmitLink is used instead of the submit for forms, BaseWicketTester does not run through the onSubmit() code of the link.
> I have stepped through the debug of the test that's actually not getting called. All my validators on the text field are getting called as expected and in fact the form works as expected when deployed so I'm thinking that it might be a WicketTester issue or the more likely scenario that I'm doing something wrong?
> Things I've tried:
> - debugging as mentioned, but this just shows me it's not getting called
> - trying to call the link directly but I just get the below exception which I'm not really surpised about.... 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-932) BaseWicketTester support for SubmitLink

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg updated WICKET-932:
---------------------------------

    Assignee: Frank Bille Jensen

> BaseWicketTester support for SubmitLink
> ---------------------------------------
>
>                 Key: WICKET-932
>                 URL: https://issues.apache.org/jira/browse/WICKET-932
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.3.0-beta2
>         Environment: XP, Tomcat
>            Reporter: Simon Comley
>            Assignee: Frank Bille Jensen
>            Priority: Minor
>             Fix For: 1.3.3
>
>         Attachments: JIRA932.zip
>
>
> When the SubmitLink is used instead of the submit for forms, BaseWicketTester does not run through the onSubmit() code of the link.
> I have stepped through the debug of the test that's actually not getting called. All my validators on the text field are getting called as expected and in fact the form works as expected when deployed so I'm thinking that it might be a WicketTester issue or the more likely scenario that I'm doing something wrong?
> Things I've tried:
> - debugging as mentioned, but this just shows me it's not getting called
> - trying to call the link directly but I just get the below exception which I'm not really surpised about.... 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-932) BaseWicketTester support for SubmitLink

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525150 ] 

Jean-Baptiste Quenot commented on WICKET-932:
---------------------------------------------

Maybe we could also add WicketTester.submitForm(String path, String alternateButtonPath) to match FormTester.submit(String alternateButtonPath)?

> BaseWicketTester support for SubmitLink
> ---------------------------------------
>
>                 Key: WICKET-932
>                 URL: https://issues.apache.org/jira/browse/WICKET-932
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.3.0-beta2
>         Environment: XP, Tomcat
>            Reporter: Simon Comley
>            Assignee: Jean-Baptiste Quenot
>            Priority: Minor
>             Fix For: 1.3.0-beta4
>
>         Attachments: JIRA932.zip
>
>
> When the SubmitLink is used instead of the submit for forms, BaseWicketTester does not run through the onSubmit() code of the link.
> I have stepped through the debug of the test that's actually not getting called. All my validators on the text field are getting called as expected and in fact the form works as expected when deployed so I'm thinking that it might be a WicketTester issue or the more likely scenario that I'm doing something wrong?
> Things I've tried:
> - debugging as mentioned, but this just shows me it's not getting called
> - trying to call the link directly but I just get the below exception which I'm not really surpised about.... 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-932) BaseWicketTester support for submitlink

Posted by "Simon Comley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Comley updated WICKET-932:
--------------------------------

    Attachment: JIRA932.zip

Example of source and testcode

> BaseWicketTester support for submitlink
> ---------------------------------------
>
>                 Key: WICKET-932
>                 URL: https://issues.apache.org/jira/browse/WICKET-932
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.3.0-beta2
>         Environment: XP, Tomcat
>            Reporter: Simon Comley
>            Priority: Minor
>             Fix For: 1.3.0-beta4
>
>         Attachments: JIRA932.zip
>
>
> When the SubmitLink is used instead of the submit for forms, BaseWicketTester does not run through the onSubmit() code of the link.
> I have stepped through the debug of the test that's actually not getting called. All my validators on the text field are getting called as expected and in fact the form works as expected when deployed so I'm thinking that it might be a WicketTester issue or the more likely scenario that I'm doing something wrong?
> Things I've tried:
> - debugging as mentioned, but this just shows me it's not getting called
> - trying to call the link directly but I just get the below exception which I'm not really surpised about.... 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-932) BaseWicketTester support for SubmitLink

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-932:
--------------------------------------

    Fix Version/s:     (was: 1.3.0-beta4)
                   1.3.0-beta5

> BaseWicketTester support for SubmitLink
> ---------------------------------------
>
>                 Key: WICKET-932
>                 URL: https://issues.apache.org/jira/browse/WICKET-932
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.3.0-beta2
>         Environment: XP, Tomcat
>            Reporter: Simon Comley
>            Assignee: Jean-Baptiste Quenot
>            Priority: Minor
>             Fix For: 1.3.0-beta5
>
>         Attachments: JIRA932.zip
>
>
> When the SubmitLink is used instead of the submit for forms, BaseWicketTester does not run through the onSubmit() code of the link.
> I have stepped through the debug of the test that's actually not getting called. All my validators on the text field are getting called as expected and in fact the form works as expected when deployed so I'm thinking that it might be a WicketTester issue or the more likely scenario that I'm doing something wrong?
> Things I've tried:
> - debugging as mentioned, but this just shows me it's not getting called
> - trying to call the link directly but I just get the below exception which I'm not really surpised about.... 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-932) BaseWicketTester support for SubmitLink

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Quenot reassigned WICKET-932:
-------------------------------------------

    Assignee:     (was: Jean-Baptiste Quenot)

> BaseWicketTester support for SubmitLink
> ---------------------------------------
>
>                 Key: WICKET-932
>                 URL: https://issues.apache.org/jira/browse/WICKET-932
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.3.0-beta2
>         Environment: XP, Tomcat
>            Reporter: Simon Comley
>            Priority: Minor
>             Fix For: 1.3.1
>
>         Attachments: JIRA932.zip
>
>
> When the SubmitLink is used instead of the submit for forms, BaseWicketTester does not run through the onSubmit() code of the link.
> I have stepped through the debug of the test that's actually not getting called. All my validators on the text field are getting called as expected and in fact the form works as expected when deployed so I'm thinking that it might be a WicketTester issue or the more likely scenario that I'm doing something wrong?
> Things I've tried:
> - debugging as mentioned, but this just shows me it's not getting called
> - trying to call the link directly but I just get the below exception which I'm not really surpised about.... 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-932) BaseWicketTester support for SubmitLink

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-932:
--------------------------------------

    Fix Version/s:     (was: 1.3.1)
                   1.3.2

> BaseWicketTester support for SubmitLink
> ---------------------------------------
>
>                 Key: WICKET-932
>                 URL: https://issues.apache.org/jira/browse/WICKET-932
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.3.0-beta2
>         Environment: XP, Tomcat
>            Reporter: Simon Comley
>            Priority: Minor
>             Fix For: 1.3.2
>
>         Attachments: JIRA932.zip
>
>
> When the SubmitLink is used instead of the submit for forms, BaseWicketTester does not run through the onSubmit() code of the link.
> I have stepped through the debug of the test that's actually not getting called. All my validators on the text field are getting called as expected and in fact the form works as expected when deployed so I'm thinking that it might be a WicketTester issue or the more likely scenario that I'm doing something wrong?
> Things I've tried:
> - debugging as mentioned, but this just shows me it's not getting called
> - trying to call the link directly but I just get the below exception which I'm not really surpised about.... 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-932) BaseWicketTester support for SubmitLink

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen resolved WICKET-932.
---------------------------------------

    Resolution: Fixed

BaseWicketTester.clickLink now submits the form correctly when using a SubmitLink as well as invoking onSubmit on the link.

> BaseWicketTester support for SubmitLink
> ---------------------------------------
>
>                 Key: WICKET-932
>                 URL: https://issues.apache.org/jira/browse/WICKET-932
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.3.0-beta2
>         Environment: XP, Tomcat
>            Reporter: Simon Comley
>            Assignee: Frank Bille Jensen
>            Priority: Minor
>             Fix For: 1.3.3
>
>         Attachments: JIRA932.zip
>
>
> When the SubmitLink is used instead of the submit for forms, BaseWicketTester does not run through the onSubmit() code of the link.
> I have stepped through the debug of the test that's actually not getting called. All my validators on the text field are getting called as expected and in fact the form works as expected when deployed so I'm thinking that it might be a WicketTester issue or the more likely scenario that I'm doing something wrong?
> Things I've tried:
> - debugging as mentioned, but this just shows me it's not getting called
> - trying to call the link directly but I just get the below exception which I'm not really surpised about.... 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-932) BaseWicketTester support for SubmitLink

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Quenot updated WICKET-932:
----------------------------------------

    Assignee: Jean-Baptiste Quenot
     Summary: BaseWicketTester support for SubmitLink  (was: BaseWicketTester support for submitlink)

> BaseWicketTester support for SubmitLink
> ---------------------------------------
>
>                 Key: WICKET-932
>                 URL: https://issues.apache.org/jira/browse/WICKET-932
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.3.0-beta2
>         Environment: XP, Tomcat
>            Reporter: Simon Comley
>            Assignee: Jean-Baptiste Quenot
>            Priority: Minor
>             Fix For: 1.3.0-beta4
>
>         Attachments: JIRA932.zip
>
>
> When the SubmitLink is used instead of the submit for forms, BaseWicketTester does not run through the onSubmit() code of the link.
> I have stepped through the debug of the test that's actually not getting called. All my validators on the text field are getting called as expected and in fact the form works as expected when deployed so I'm thinking that it might be a WicketTester issue or the more likely scenario that I'm doing something wrong?
> Things I've tried:
> - debugging as mentioned, but this just shows me it's not getting called
> - trying to call the link directly but I just get the below exception which I'm not really surpised about.... 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-932) BaseWicketTester support for SubmitLink

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-932:
--------------------------------------

    Fix Version/s:     (was: 1.3.0-rc1)
                   1.3.0-rc2

> BaseWicketTester support for SubmitLink
> ---------------------------------------
>
>                 Key: WICKET-932
>                 URL: https://issues.apache.org/jira/browse/WICKET-932
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.3.0-beta2
>         Environment: XP, Tomcat
>            Reporter: Simon Comley
>            Assignee: Jean-Baptiste Quenot
>            Priority: Minor
>             Fix For: 1.3.0-rc2
>
>         Attachments: JIRA932.zip
>
>
> When the SubmitLink is used instead of the submit for forms, BaseWicketTester does not run through the onSubmit() code of the link.
> I have stepped through the debug of the test that's actually not getting called. All my validators on the text field are getting called as expected and in fact the form works as expected when deployed so I'm thinking that it might be a WicketTester issue or the more likely scenario that I'm doing something wrong?
> Things I've tried:
> - debugging as mentioned, but this just shows me it's not getting called
> - trying to call the link directly but I just get the below exception which I'm not really surpised about.... 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-932) BaseWicketTester support for SubmitLink

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-932:
--------------------------------------

    Fix Version/s:     (was: 1.3.0-rc2)
                   1.3.0-rc3

> BaseWicketTester support for SubmitLink
> ---------------------------------------
>
>                 Key: WICKET-932
>                 URL: https://issues.apache.org/jira/browse/WICKET-932
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.3.0-beta2
>         Environment: XP, Tomcat
>            Reporter: Simon Comley
>            Assignee: Jean-Baptiste Quenot
>            Priority: Minor
>             Fix For: 1.3.0-rc3
>
>         Attachments: JIRA932.zip
>
>
> When the SubmitLink is used instead of the submit for forms, BaseWicketTester does not run through the onSubmit() code of the link.
> I have stepped through the debug of the test that's actually not getting called. All my validators on the text field are getting called as expected and in fact the form works as expected when deployed so I'm thinking that it might be a WicketTester issue or the more likely scenario that I'm doing something wrong?
> Things I've tried:
> - debugging as mentioned, but this just shows me it's not getting called
> - trying to call the link directly but I just get the below exception which I'm not really surpised about.... 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.