You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by Graeme-Miller <gi...@git.apache.org> on 2015/12/07 14:59:42 UTC
[GitHub] incubator-brooklyn pull request: QA Updates for Clocker
GitHub user Graeme-Miller opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1091
QA Updates for Clocker
TestCase no longer extends BaseTest, but rather extends Entity directly. Added check in TestCaseImpl to ensure that only non-started children are startable. Added InfrastructureDeploymentTestCase
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Graeme-Miller/incubator-brooklyn qa_add_infrastructure_entity_tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1091.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1091
----
commit 2b40644d83601773d368d4416bd5fb938e673f5a
Author: Graeme-Miller <gr...@cloudsoftcorp.com>
Date: 2015-12-04T19:32:28Z
TestCase no longer extends BaseTest, but rather extends Entity directly. Added check in TestCaseImpl to ensure that only non-started children are startable. Added InfrastructureDeploymentTestCase
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: QA Updates for Clocker
Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1091#discussion_r46828080
--- Diff: usage/test-framework/src/main/java/org/apache/brooklyn/test/framework/TestCase.java ---
@@ -26,5 +28,5 @@
* @author m4rkmckenna
*/
@ImplementedBy(value = TestCaseImpl.class)
-public interface TestCase extends BaseTest {
+public interface TestCase extends Entity, Startable {
--- End diff --
LGTM, shouldn't have extended BaseTest to begin with
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: QA Updates for Clocker
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1091
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: QA Updates for Clocker
Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1091#issuecomment-162540024
@Graeme-Miller could you share an example `InfrastructureDeploymentTestCase ` test yml please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: QA Updates for Clocker
Posted by Graeme-Miller <gi...@git.apache.org>.
Github user Graeme-Miller commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1091#issuecomment-162544360
@johnmccabe yup, there you go:
```YAML
services:
- type: org.apache.brooklyn.test.framework.InfrastructureDeploymentTestCase
brooklyn.config:
infrastructure.deployment.location.sensor: entity.dynamicLocation
infrastructure.deployment.spec:
$brooklyn:entitySpec:
- type: brooklyn.entity.container.docker.DockerInfrastructure
id: infrastructure
location: named:softlayer-sea01
brooklyn.config:
entity.dynamicLocation.name: my-docker-cloud
docker.host.cluster.initial.size: 1
docker.registry.start: false
docker.version: 1.7.1
infrastructure.deployment.entity.spec:
$brooklyn:entitySpec:
- type: org.apache.brooklyn.entity.webapp.jboss.JBoss7Server
id: JBoss7Server
brooklyn.children:
- type: org.apache.brooklyn.test.framework.TestSensor
name: Check infrastructure isUp
targetId: infrastructure
sensor: service.isUp
timeout: 10m
assert:
- equals: true
- type: org.apache.brooklyn.test.framework.TestSensor
name: Check redis isUp
targetId: JBoss7Server
sensor: service.isUp
timeout: 10m
assert:
- equals: true
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---