You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2013/04/12 14:28:17 UTC

[jira] [Resolved] (SLING-2820) Resource set should be sorted on demand

     [ https://issues.apache.org/jira/browse/SLING-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler resolved SLING-2820.
-------------------------------------

    Resolution: Fixed

Fixed in revision 1467250
I switched from a set to a list which is now sorted on demand. Given that usually the list contains a single entry and in some cases maybe two or three, the extra sorting doesn't really make a difference in terms of performance
                
> Resource set should be sorted on demand
> ---------------------------------------
>
>                 Key: SLING-2820
>                 URL: https://issues.apache.org/jira/browse/SLING-2820
>             Project: Sling
>          Issue Type: Bug
>          Components: Installer
>    Affects Versions: Installer Core 3.4.6
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>             Fix For: Installer Core 3.4.8
>
>
> The EntityResourceList stores a sorted set of TaskResources - however, this is sorted on modifications of the set only but the TaskResources are changed underneath which has an effect on the sort order.
> This might lead to a wrong sorting.
> We should rather sort the set on demand - the other option would be to do a trigger based sort, but this would make the code ugly as all modifications of a TaskResource need to be propagated to the containing set.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira