You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "bjornjorgensen (via GitHub)" <gi...@apache.org> on 2023/02/26 17:47:56 UTC
[GitHub] [spark] bjornjorgensen opened a new pull request, #40178: [MINOR][FOLLOWUP] Remove Jenkins from web page.
bjornjorgensen opened a new pull request, #40178:
URL: https://github.com/apache/spark/pull/40178
### What changes were proposed in this pull request?
Remove Jenkins from web page.
This is a followup on https://github.com/apache/spark-website/pull/442
### Why are the changes needed?
We don't use Jenkins anymore so we should update doc.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a diff in pull request #40178: [MINOR][DOCS][FOLLOWUP] Remove `Jenkins` from web page.
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #40178:
URL: https://github.com/apache/spark/pull/40178#discussion_r1118205272
##########
docs/building-spark.md:
##########
@@ -276,34 +276,6 @@ Enable the profile (e.g. 2.13):
# For sbt
./build/sbt -Pscala-2.13 compile
-## Running Jenkins tests with GitHub Enterprise
Review Comment:
As the script is still there, I'm also not sure why we need to remove this doc? Maybe it is better to update it as Apache Spark doesn't use it to report Jenkins tests to Github anymore, but the script is used to do that and still available to users?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #40178: [MINOR][DOCS] Remove `Jenkins` from web page.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #40178: [MINOR][DOCS] Remove `Jenkins` from web page.
URL: https://github.com/apache/spark/pull/40178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #40178: [MINOR][DOCS][FOLLOWUP] Remove `Jenkins` from web page.
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #40178:
URL: https://github.com/apache/spark/pull/40178#discussion_r1118182170
##########
docs/building-spark.md:
##########
@@ -276,34 +276,6 @@ Enable the profile (e.g. 2.13):
# For sbt
./build/sbt -Pscala-2.13 compile
-## Running Jenkins tests with GitHub Enterprise
Review Comment:
Hmmm .. yeah Apache Spark itself doesn't use this script for now as far as I know but wouldn't it be worthwhile keeping it in case other people build their own Jenkins? To be clear, I am fine with removing this out but I wouldn't remove if anyone actually has a concern or uses it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #40178: [MINOR][DOCS][FOLLOWUP] Remove `Jenkins` from web page.
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #40178:
URL: https://github.com/apache/spark/pull/40178#issuecomment-1445501633
Lastly, are you claiming a followup across `spark-website` and `spark` repositories? To me, `[FOLLOWUP]` doesn't make sense at all in that case, @bjornjorgensen .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bjornjorgensen commented on pull request #40178: [MINOR][DOCS][FOLLOWUP] Remove `Jenkins` from web page.
Posted by "bjornjorgensen (via GitHub)" <gi...@apache.org>.
bjornjorgensen commented on PR #40178:
URL: https://github.com/apache/spark/pull/40178#issuecomment-1445419415
And CC @xinrong-meng This is for updating documentation for spark 3.4 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #40178: [MINOR][DOCS][FOLLOWUP] Remove `Jenkins` from web page.
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #40178:
URL: https://github.com/apache/spark/pull/40178#discussion_r1118182170
##########
docs/building-spark.md:
##########
@@ -276,34 +276,6 @@ Enable the profile (e.g. 2.13):
# For sbt
./build/sbt -Pscala-2.13 compile
-## Running Jenkins tests with GitHub Enterprise
Review Comment:
Hmmm .. yeah Apache Spark itself use this script for now as far as I know but wouldn't it be worthwhile keeping it in case other people build their own Jenkins? To be clear, I am fine with removing this out but I wouldn't remove if anyone actually has a concern or uses it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #40178: [MINOR][DOCS][FOLLOWUP] Remove `Jenkins` from web page.
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #40178:
URL: https://github.com/apache/spark/pull/40178#issuecomment-1445501146
To be clear, the code change itself looks okay, @bjornjorgensen .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bjornjorgensen commented on pull request #40178: [MINOR][DOCS][FOLLOWUP] Remove `Jenkins` from web page.
Posted by "bjornjorgensen (via GitHub)" <gi...@apache.org>.
bjornjorgensen commented on PR #40178:
URL: https://github.com/apache/spark/pull/40178#issuecomment-1445418994
@srowen @dongjoon-hyun @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #40178: [MINOR][DOCS][FOLLOWUP] Remove `Jenkins` from web page.
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #40178:
URL: https://github.com/apache/spark/pull/40178#issuecomment-1445501723
Also, cc @HyukjinKwon .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #40178: [MINOR][DOCS] Remove `Jenkins` from web page.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40178:
URL: https://github.com/apache/spark/pull/40178#issuecomment-1581691623
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org