[GitHub] [hive] dlavati commented on a change in pull request #550: HIVE-21198 Introduce a database object reference class

[GitBox <gi...@apache.org>]

dlavati commented on a change in pull request #550: HIVE-21198 Introduce a database object reference class
URL: https://github.com/apache/hive/pull/550#discussion_r344107895
 
 

 ##########
 File path: metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreUtils.java
 ##########
 @@ -154,7 +154,7 @@ static public Deserializer getDeserializer(Configuration conf,
     ObjectInspector oi = deserializer.getObjectInspector();
     String[] names = tableName.split("\\.");
     String last_name = names[names.length - 1];
-    for (int i = 1; i < names.length; i++) {
+    for (int i = 2; i < names.length; i++) {
 
 Review comment:
   This used to split e.g. `mytable.field1`, however now we're always passing `mydb.mytable.field1`. I can leave a comment to clarify this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org