You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by fr...@apache.org on 2026/09/04 08:09:11 UTC
(logging-log4net) 03/04: credit the fixer in every changelog entry
This is an automated email from the ASF dual-hosted git repository.
FreeAndNil pushed a commit to branch Feature/316-content-loss
in repository https://gitbox.apache.org/repos/asf/logging-log4net.git
commit 39033a49a0bc6eb22ec17313566eb680e91f34cc
Author: Jan Friedrich <fr...@apache.org>
AuthorDate: Thu Sep 3 23:21:16 2026 +0200
credit the fixer in every changelog entry
CLAUDE.md wants the description to close with both sides, who raised it and who
did the work. Eleven entries named only the audit finding. Nothing but the
attribution changed.
---
src/changelog/3.5.0/313-redact-connection-string-allowlist.xml | 2 +-
src/changelog/3.5.0/313-require-powershell-74.xml | 2 +-
src/changelog/3.5.0/313-verify-release-keys-bypass.xml | 2 +-
src/changelog/3.5.0/315-eventlog-nul.xml | 2 +-
src/changelog/3.5.0/315-eventlog-size-budget.xml | 2 +-
src/changelog/3.5.0/315-local-syslog-newlines.xml | 2 +-
src/changelog/3.5.0/315-outputdebugstring-nul.xml | 2 +-
src/changelog/3.5.0/315-pickup-dir-unencodable-content.xml | 2 +-
src/changelog/3.5.0/315-syslog-non-ascii.xml | 2 +-
src/changelog/3.5.0/315-telnet-unencodable-content.xml | 2 +-
src/changelog/3.5.0/316-ansi-empty-render.xml | 2 +-
11 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/changelog/3.5.0/313-redact-connection-string-allowlist.xml b/src/changelog/3.5.0/313-redact-connection-string-allowlist.xml
index 0aec3b5d..e020b60a 100644
--- a/src/changelog/3.5.0/313-redact-connection-string-allowlist.xml
+++ b/src/changelog/3.5.0/313-redact-connection-string-allowlist.xml
@@ -8,6 +8,6 @@
keep secrets out of the `AdoNetAppender` message for a connection it could not open. Hiding
password-bearing keywords missed `Extended Properties`, which nests a whole connection string, and
keywords such as `AccessToken` (CWE-532). Only keywords naming the server and account are kept now
- (audit da18b6fd-f028)
+ (audit da18b6fd-f028, fixed by @FreeAndNil)
</description>
</entry>
diff --git a/src/changelog/3.5.0/313-require-powershell-74.xml b/src/changelog/3.5.0/313-require-powershell-74.xml
index 3222a5e4..e0ab2306 100644
--- a/src/changelog/3.5.0/313-require-powershell-74.xml
+++ b/src/changelog/3.5.0/313-require-powershell-74.xml
@@ -9,6 +9,6 @@
`$PSNativeCommandUseErrorActionPreference`, which exists only from 7.4, so under Windows PowerShell
5.1 a failing `gpg --verify` was ignored and `verify-release.ps1` reported success and exited 0. The
scripts now refuse to start on an older host, and the review instructions install PowerShell 7 and
- run the script with `pwsh` (audit 1231d72-f009)
+ run the script with `pwsh` (audit 1231d72-f009, implemented by @FreeAndNil)
</description>
</entry>
diff --git a/src/changelog/3.5.0/313-verify-release-keys-bypass.xml b/src/changelog/3.5.0/313-verify-release-keys-bypass.xml
index e49e157c..215ad438 100644
--- a/src/changelog/3.5.0/313-verify-release-keys-bypass.xml
+++ b/src/changelog/3.5.0/313-verify-release-keys-bypass.xml
@@ -10,6 +10,6 @@
and was imported into the verification key ring, and artifacts signed by whoever placed it verified
(CWE-347). The scripts now verify in a GnuPG home of their own, filled from a copy downloaded
there, rather than with `--keyring`, which `gpg` ignores where `common.conf` sets `use-keyboxd`.
- Present in 3.2.0 onward, since the script was added (audit da18b6fd-f003, reported by @swebb2066)
+ Present in 3.2.0 onward, since the script was added (audit da18b6fd-f003, reported by @swebb2066, fixed by @FreeAndNil)
</description>
</entry>
diff --git a/src/changelog/3.5.0/315-eventlog-nul.xml b/src/changelog/3.5.0/315-eventlog-nul.xml
index 2ac7a56f..117ad85f 100644
--- a/src/changelog/3.5.0/315-eventlog-nul.xml
+++ b/src/changelog/3.5.0/315-eventlog-nul.xml
@@ -10,6 +10,6 @@
the layout rendered after it, exception text and trailing fields included (CWE-158). `WriteEntry`
raises nothing, so the record simply stored short. Measured on Windows 11 build 26200: of a 45
character message with a NUL at 23, the 23 character prefix was stored and the rest was gone
- (audit da18b6fd-f007)
+ (audit da18b6fd-f007, fixed by @FreeAndNil)
</description>
</entry>
diff --git a/src/changelog/3.5.0/315-eventlog-size-budget.xml b/src/changelog/3.5.0/315-eventlog-size-budget.xml
index faa41f34..5a38f539 100644
--- a/src/changelog/3.5.0/315-eventlog-size-budget.xml
+++ b/src/changelog/3.5.0/315-eventlog-size-budget.xml
@@ -12,6 +12,6 @@
that the service stores nothing and reports nothing. The whole event was lost rather than
shortened, and `applicationName` defaults to the app domain name, so a consumer with a long
assembly name lost more. The limit is now computed, and a truncation is reported through the
- error handler, which is the only signal available (audit da18b6fd-f030)
+ error handler, which is the only signal available (audit da18b6fd-f030, fixed by @FreeAndNil)
</description>
</entry>
diff --git a/src/changelog/3.5.0/315-local-syslog-newlines.xml b/src/changelog/3.5.0/315-local-syslog-newlines.xml
index 4c7a6a47..3b002e42 100644
--- a/src/changelog/3.5.0/315-local-syslog-newlines.xml
+++ b/src/changelog/3.5.0/315-local-syslog-newlines.xml
@@ -10,6 +10,6 @@
records everything after the newline as its own entry, so content could forge an authentic
looking record (CWE-117). `NewLineHandling` mirrors the option of the same name on
`RemoteSyslogAppender`, which already escaped by default; set it to `Keep` for the previous
- behaviour (audit da18b6fd-f008)
+ behaviour (audit da18b6fd-f008, fixed by @FreeAndNil)
</description>
</entry>
diff --git a/src/changelog/3.5.0/315-outputdebugstring-nul.xml b/src/changelog/3.5.0/315-outputdebugstring-nul.xml
index b2adef68..0ed4c455 100644
--- a/src/changelog/3.5.0/315-outputdebugstring-nul.xml
+++ b/src/changelog/3.5.0/315-outputdebugstring-nul.xml
@@ -8,6 +8,6 @@
escape NUL characters in `OutputDebugStringAppender` content. `OutputDebugStringW` takes a null
terminated string, so a NUL in logged content ended the record there and silently dropped whatever
the layout rendered after it, exception text and trailing fields included (CWE-158). The escape
- `LocalSyslogAppender` already applied is now shared between the two (audit da18b6fd-f009)
+ `LocalSyslogAppender` already applied is now shared between the two (audit da18b6fd-f009, fixed by @FreeAndNil)
</description>
</entry>
diff --git a/src/changelog/3.5.0/315-pickup-dir-unencodable-content.xml b/src/changelog/3.5.0/315-pickup-dir-unencodable-content.xml
index 8f952bf1..7953e8bc 100644
--- a/src/changelog/3.5.0/315-pickup-dir-unencodable-content.xml
+++ b/src/changelog/3.5.0/315-pickup-dir-unencodable-content.xml
@@ -8,6 +8,6 @@
stop one logging event destroying a whole `SmtpPickupDirAppender` batch. `File.CreateText`
throws on content it cannot encode, such as an unpaired surrogate, which abandoned every buffered
event and left a truncated mail in the pickup directory for the service to send. Such content is
- now written as a `\uXXXX` escape (audit da18b6fd-f011)
+ now written as a `\uXXXX` escape (audit da18b6fd-f011, fixed by @FreeAndNil)
</description>
</entry>
diff --git a/src/changelog/3.5.0/315-syslog-non-ascii.xml b/src/changelog/3.5.0/315-syslog-non-ascii.xml
index e8020168..edcf04df 100644
--- a/src/changelog/3.5.0/315-syslog-non-ascii.xml
+++ b/src/changelog/3.5.0/315-syslog-non-ascii.xml
@@ -9,6 +9,6 @@
allows only the visible ASCII characters and space, and everything else was dropped silently, so
`Schönwetter 你好` reached the collector as `Schnwetter ` and a tab disappeared
from between its neighbours. Such characters are now written as a `\uXXXX` escape, which keeps
- the record inside the allowed range and readable (audit da18b6fd-f035)
+ the record inside the allowed range and readable (audit da18b6fd-f035, fixed by @FreeAndNil)
</description>
</entry>
diff --git a/src/changelog/3.5.0/315-telnet-unencodable-content.xml b/src/changelog/3.5.0/315-telnet-unencodable-content.xml
index ad96651f..d1b44771 100644
--- a/src/changelog/3.5.0/315-telnet-unencodable-content.xml
+++ b/src/changelog/3.5.0/315-telnet-unencodable-content.xml
@@ -8,6 +8,6 @@
stop one logging event disconnecting every `TelnetAppender` client. The default writer encoding
throws on content it cannot encode, such as an unpaired surrogate, and `Send` reads any failure as
a client that hung up. Unpaired surrogates are now written as a `\uXXXX` escape, as elsewhere
- (audit da18b6fd-f013)
+ (audit da18b6fd-f013, fixed by @FreeAndNil)
</description>
</entry>
diff --git a/src/changelog/3.5.0/316-ansi-empty-render.xml b/src/changelog/3.5.0/316-ansi-empty-render.xml
index bf01d9ca..1f32068d 100644
--- a/src/changelog/3.5.0/316-ansi-empty-render.xml
+++ b/src/changelog/3.5.0/316-ansi-empty-render.xml
@@ -8,6 +8,6 @@
stop `AnsiColorTerminalAppender` dropping an event that renders to nothing. The branch meant
for a single character read the first one without checking there was one, so an empty render
threw and the event was lost. The reset codes are now placed by one computed offset, which has no
- special case to get wrong (audit da18b6fd-f029)
+ special case to get wrong (audit da18b6fd-f029, fixed by @FreeAndNil)
</description>
</entry>