You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "abhishekagarwal87 (via GitHub)" <gi...@apache.org> on 2023/05/29 08:26:19 UTC

[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #14348: Fix flaky Revised ITs failures on GHA runners

abhishekagarwal87 commented on code in PR #14348:
URL: https://github.com/apache/druid/pull/14348#discussion_r1209061774


##########
.github/workflows/reusable-revised-its.yml:
##########
@@ -118,6 +120,12 @@ jobs:
           echo $DRUID_IT_IMAGE_NAME
           docker save "$DRUID_IT_IMAGE_NAME" | gzip > druid-container-jdk${{ inputs.build_jdk }}.tar.gz
 
+      - name: Stop and remove docker containers
+        run: |
+          echo "Force stopping all containers and pruning"
+          docker ps -aq | xargs -r docker rm -f

Review Comment:
   I am wondering if we should stop all containers. Instead, we can add labels to `services` in the docker-compose files and then remove the containers with those labels instead. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org