[jira] [Commented] (PIG-3779) Assert constructs ConstantExpression with null when no comment is given

["Cheolsoo Park (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-3779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912187#comment-13912187 ] 

Cheolsoo Park commented on PIG-3779:
------------------------------------

+1.

I will commit it tomorrow.

> Assert constructs ConstantExpression with null when no comment is given
> -----------------------------------------------------------------------
>
>                 Key: PIG-3779
>                 URL: https://issues.apache.org/jira/browse/PIG-3779
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Cheolsoo Park
>            Assignee: Jacob Perkins
>             Fix For: 0.13.0
>
>         Attachments: assert.diff
>
>
> I ran into this problem with Lipstick after deploying ASSERT. When ASSERT is not given any comment, LogicalPlanBuilder constructs ConstantExpression with null. Later tools like Lipstick try to convert it to a String resulting in NPE.
> Although it's possible to handle this case in Lipstick, I feel ConstantExpression shouldn't be constructed with null in the first place.
> Here is the code in LogicalPlanBuilder-
> {code}
> ConstantExpression constExpr = new ConstantExpression(exprPlan, comment);
> {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)