[GitHub] [arrow] kou commented on a diff in pull request #34054: GH-34053: [C++][Parquet] Write parquet page index

["kou (via GitHub)" <gi...@apache.org>]

kou commented on code in PR #34054:
URL: https://github.com/apache/arrow/pull/34054#discussion_r1117608291


##########
cpp/src/parquet/statistics.cc:
##########
@@ -494,6 +494,8 @@ class TypedStatisticsImpl : public TypedStatistics<DType> {
                       int64_t null_count, int64_t distinct_count, bool has_min_max,
                       bool has_null_count, bool has_distinct_count, MemoryPool* pool)
       : TypedStatisticsImpl(descr, pool) {
+    has_null_count_ = has_null_count;
+    has_distinct_count_ = has_distinct_count;

Review Comment:
   This is related to the GLib failure.
   If this is a correct change, we can change the GLib test:
   
   ```diff
   diff --git a/c_glib/test/parquet/test-statistics.rb b/c_glib/test/parquet/test-statistics.rb
   index 4f21ebf00c..0367084c88 100644
   --- a/c_glib/test/parquet/test-statistics.rb
   +++ b/c_glib/test/parquet/test-statistics.rb
   @@ -51,7 +51,7 @@ class TestParquetStatistics < Test::Unit::TestCase
    
      test("#has_n_distinct_values?") do
        assert do
   -      @statistics.has_n_distinct_values?
   +      not @statistics.has_n_distinct_values?
        end
      end
    
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org